New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLICKHOUSE-4523 Fix "Column '0' already exists" in SELECT .. PREWHERE on column with DEFAULT #5397
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d6b81c1
CLICKHOUSE-4523 Fix "Column '0' already exists" in SELECT .. PREWHERE…
proller 58066cd
fix style
proller 4000b57
Fix build
proller cc61079
Update iostream_debug_helpers.cpp
alexey-milovidov d8c61b6
Update evaluateMissingDefaults.cpp
alexey-milovidov File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
dbms/tests/queries/0_stateless/00950_default_prewhere.reference
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
42 | ||
42 42 42 | ||
42 42 43 | ||
43 | ||
43 | ||
43 | ||
42 42 43 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
|
||
DROP TABLE IF EXISTS test_generic_events_all; | ||
|
||
CREATE TABLE test_generic_events_all (APIKey UInt8, SessionType UInt8) ENGINE = MergeTree() PARTITION BY APIKey ORDER BY tuple(); | ||
INSERT INTO test_generic_events_all VALUES( 42, 42 ); | ||
ALTER TABLE test_generic_events_all ADD COLUMN OperatingSystem UInt64 DEFAULT 42; | ||
SELECT OperatingSystem FROM test_generic_events_all PREWHERE APIKey = 42 WHERE SessionType = 42; | ||
SELECT * FROM test_generic_events_all PREWHERE APIKey = 42 WHERE SessionType = 42; | ||
|
||
DROP TABLE IF EXISTS test_generic_events_all; | ||
|
||
CREATE TABLE test_generic_events_all (APIKey UInt8, SessionType UInt8) ENGINE = MergeTree() PARTITION BY APIKey ORDER BY tuple(); | ||
INSERT INTO test_generic_events_all VALUES( 42, 42 ); | ||
ALTER TABLE test_generic_events_all ADD COLUMN OperatingSystem UInt64 DEFAULT SessionType+1; | ||
SELECT * FROM test_generic_events_all WHERE APIKey = 42 AND SessionType = 42; | ||
SELECT OperatingSystem FROM test_generic_events_all WHERE APIKey = 42; | ||
SELECT OperatingSystem FROM test_generic_events_all WHERE APIKey = 42 AND SessionType = 42; | ||
SELECT OperatingSystem FROM test_generic_events_all PREWHERE APIKey = 42 WHERE SessionType = 42; | ||
SELECT * FROM test_generic_events_all PREWHERE APIKey = 42 WHERE SessionType = 42; | ||
|
||
DROP TABLE IF EXISTS test_generic_events_all; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
DROP TABLE IF EXISTS test_generic_events_all; | ||
CREATE TABLE test_generic_events_all (APIKey UInt8, SessionType UInt8) ENGINE = MergeTree() PARTITION BY APIKey ORDER BY tuple(); | ||
INSERT INTO test_generic_events_all VALUES( 42, 42 ); | ||
ALTER TABLE test_generic_events_all ADD COLUMN OperatingSystem UInt64 DEFAULT APIKey+1; | ||
SELECT * FROM test_generic_events_all WHERE APIKey = 42 AND SessionType = 42; | ||
-- InterpreterSelectQuery: MergeTreeWhereOptimizer: condition "APIKey = 42" moved to PREWHERE | ||
SELECT OperatingSystem FROM test_generic_events_all WHERE APIKey = 42; | ||
SELECT OperatingSystem FROM test_generic_events_all WHERE APIKey = 42 AND SessionType = 42; | ||
SELECT OperatingSystem FROM test_generic_events_all PREWHERE APIKey = 42 WHERE SessionType = 42; | ||
SELECT * FROM test_generic_events_all PREWHERE APIKey = 42 WHERE SessionType = 42; | ||
|
||
DROP TABLE IF EXISTS test_generic_events_all; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Five whitespaces!