New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix possible type mismatch with IPv4 #54212
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc: @yakov-olkhovskiy not sure if this fix is reasonable, but decided to give it a try regardless. |
robot-clickhouse-ci-1
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Sep 2, 2023
This is an automated comment for commit 2c8fd5d with description of existing statuses. It's updated for the latest CI running
|
alexey-milovidov
added
the
can be tested
Allows running workflows for external contributors
label
Sep 2, 2023
CurtizJ
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-bugfix
Pull request with bugfix, not backported by default
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPv4 native type was added in v23.3-lts. Now a query like the following could fail:
Possible work around is:
Observed a similar error with some of the queries when upgrading from v22.3-ltes to v23.3-lts, for example:
Since IPv4 type was UInt64 before and it's possible with the new native IPv4 type, select query from a IPv4 column type might error in the example above.
Always converting IPv4 to UInt32 if the src type is UInt64 seems to be one of the solutions that seems to work. This is probably equivalent to using
toUInt32
explicitly in the query.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix possible type mismatch with IPv4.
Related to #54160.