New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unexpected errors in system.errors after join #54306
Conversation
This is an automated comment for commit d048e09 with description of existing statuses. It's updated for the latest CI running
|
51074b8
to
d048e09
Compare
} | ||
catch (DB::Exception &) | ||
{ | ||
/// not a constant expression |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This type of code is always wrong because there can be a memory limit exception, fault injection, or anything else.
Interesting how we can prevent having this code in other places.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
system.errors
after join, close system.errors contains errors about UNKNOWN_IDENTIFIER but result of query correctly returns #51487Documentation entry for user-facing changes