New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix possible error 'URI contains invalid characters' in s3 table function #54373
Fix possible error 'URI contains invalid characters' in s3 table function #54373
Conversation
} | ||
|
||
configuration.keys = {configuration.url.key}; | ||
|
||
if (configuration.format == "auto") | ||
configuration.format = FormatFactory::instance().getFormatFromFileName(Poco::URI(configuration.url.uri.getPath()).getPath(), true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem was here in Poco::URI(configuration.url.uri.getPath()).getPath()
. Initially it was a workaround to extract correct filename from url with query parameters, because S3::URI encoded ?
symbol. Now I just use initial url here, so nothing is encoded and getPath()
method returns path without query parameters
This is an automated comment for commit c6ef811 with description of existing statuses. It's updated for the latest CI running
|
…racters' in s3 table function
Backport #54373 to 23.8: Fix possible error 'URI contains invalid characters' in s3 table function
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix possible error 'URI contains invalid characters' in s3 table function. Closes #54345
Documentation entry for user-facing changes