Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
addDate
function for compatibility with MySQL #54400Add
addDate
function for compatibility with MySQL #54400Changes from 2 commits
b06412a
9a3ea9d
cf66271
e648646
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe test what happens if addition moves the result beyond the bounds of the date time type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The behavior will be the same as in the case with the
+
or-
operations:1900-01-01 00:00:00.000
with the required precision.In MySQL we simply get NULL. Should we try to replicate this behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, if the result is outside the bounds of the data type, we say that the result is undefined.
The same semantics is used in
makeDate()
: https://fiddle.clickhouse.com/e58005b1-95f7-49fd-9989-10e295bfb82fIn my view, there is no need to replicate MySQL's behavior, it is more important to stay consistent within ClickHouse's functions and it's an edge case anyways.