New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reproduce and fix the bug in removeSharedRecursive #54430
reproduce and fix the bug in removeSharedRecursive #54430
Conversation
This is an automated comment for commit d5268f3 with description of existing statuses. It's updated for the latest CI running
|
12a87af
to
fd8a65d
Compare
fd8a65d
to
44e432d
Compare
d53b781
to
0f03577
Compare
0f03577
to
1298dba
Compare
@@ -203,6 +203,7 @@ struct RemoveManyObjectStorageOperation final : public IDiskObjectStorageOperati | |||
if (unlink_outcome && !keep_all_batch_data && !file_names_remove_metadata_only.contains(fs::path(path).filename())) | |||
{ | |||
objects_to_remove.emplace_back(ObjectsToRemove{std::move(objects), std::move(unlink_outcome)}); | |||
removed_files.push_back(path); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removed_files
is a bit confusing. Moreover, we already have remove_paths
in the same scope
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Will change this naming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
paths_removed_with_objects
long but verbose.
01051_system_stack_trace |
Backport #54430 to 23.8: reproduce and fix the bug in removeSharedRecursive
Backport #54430 to 23.7: reproduce and fix the bug in removeSharedRecursive
Backport #54430 to 23.6: reproduce and fix the bug in removeSharedRecursive
Backport #54430 to 23.3: reproduce and fix the bug in removeSharedRecursive
…54430 Revert "Backport #54430 to 23.3: reproduce and fix the bug in removeSharedRecursive"
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Reproduce the bug described here #54135
When detached part is deleted, removeSharedRecursive is called for its directory. That call deletes all shared data inside projections despite information about hard linked files inside.