Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reproduce and fix the bug in removeSharedRecursive #54430

Merged
merged 4 commits into from Sep 11, 2023

Conversation

CheSema
Copy link
Member

@CheSema CheSema commented Sep 7, 2023

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Reproduce the bug described here #54135

When detached part is deleted, removeSharedRecursive is called for its directory. That call deletes all shared data inside projections despite information about hard linked files inside.

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-bugfix Pull request with bugfix, not backported by default label Sep 7, 2023
@robot-clickhouse-ci-2
Copy link
Contributor

robot-clickhouse-ci-2 commented Sep 7, 2023

This is an automated comment for commit d5268f3 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
Bugfix validate checkChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🔴 failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@CheSema CheSema force-pushed the remove-recursive-with-projection branch from 12a87af to fd8a65d Compare September 7, 2023 21:52
@CheSema CheSema force-pushed the remove-recursive-with-projection branch from fd8a65d to 44e432d Compare September 7, 2023 22:21
@tavplubix tavplubix self-assigned this Sep 8, 2023
@CheSema CheSema changed the title reproduce a bug in removeSharedRecursive reproduce and fix the bug in removeSharedRecursive Sep 9, 2023
@CheSema CheSema force-pushed the remove-recursive-with-projection branch 2 times, most recently from d53b781 to 0f03577 Compare September 9, 2023 12:06
@CheSema CheSema force-pushed the remove-recursive-with-projection branch from 0f03577 to 1298dba Compare September 9, 2023 13:55
@CheSema CheSema marked this pull request as ready for review September 9, 2023 13:55
@@ -203,6 +203,7 @@ struct RemoveManyObjectStorageOperation final : public IDiskObjectStorageOperati
if (unlink_outcome && !keep_all_batch_data && !file_names_remove_metadata_only.contains(fs::path(path).filename()))
{
objects_to_remove.emplace_back(ObjectsToRemove{std::move(objects), std::move(unlink_outcome)});
removed_files.push_back(path);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removed_files is a bit confusing. Moreover, we already have remove_paths in the same scope

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Will change this naming.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paths_removed_with_objects long but verbose.

@CheSema
Copy link
Member Author

CheSema commented Sep 11, 2023

01051_system_stack_trace
01052_window_view_proc_tumble_to_now
both are flaky

@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Sep 12, 2023
CheSema added a commit that referenced this pull request Sep 12, 2023
Backport #54430 to 23.8: reproduce and fix the bug in removeSharedRecursive
CheSema added a commit that referenced this pull request Sep 12, 2023
Backport #54430 to 23.7: reproduce and fix the bug in removeSharedRecursive
CheSema added a commit that referenced this pull request Sep 12, 2023
Backport #54430 to 23.6: reproduce and fix the bug in removeSharedRecursive
tavplubix added a commit that referenced this pull request Sep 14, 2023
Backport #54430 to 23.3: reproduce and fix the bug in removeSharedRecursive
tavplubix added a commit that referenced this pull request Sep 16, 2023
robot-ch-test-poll2 added a commit that referenced this pull request Sep 17, 2023
…54430

Revert "Backport #54430 to 23.3: reproduce and fix the bug in removeSharedRecursive"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants