New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix possible incorrect result with SimpleAggregateFunction in PREWHERE and FINAL #54436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll3
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Sep 8, 2023
This is an automated comment for commit 24c0d53 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
azat
force-pushed
the
prewhere-filter-fix
branch
from
September 8, 2023 09:38
baaa688
to
c5918fc
Compare
nickitat
reviewed
Sep 11, 2023
azat
force-pushed
the
prewhere-filter-fix
branch
2 times, most recently
from
September 20, 2023 17:56
439ef51
to
5eae132
Compare
azat
changed the title
RFC: Fix PREWHERE with FINAL (forbid reusing expression calculated on PREWHERE step)
Fix possible incorrect result with SimpleAggregateFunction in PREWHERE and FINAL
Sep 20, 2023
nickitat
reviewed
Sep 23, 2023
…E and FINAL In case of FINAL the result of the expression for PREWHERE can be changed after applying merge algorithm, and this is the problem for SimpleAggregateFunction since after applying merging algorithm the value can be changed. Note, analyzer does not has this bug because it simply does not reuse columns from PREWHERE (they does not passed via GlobalPlannerContext::createColumnIdentifier()) Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com> v2: update tests references (see https://s3.amazonaws.com/clickhouse-test-reports/54436/baaa688f40fcd064952f62dc8c62ddc752dd0046/fast_test.html) v3: allow reusing expression from PREWHERE w/o FINAL and revert tests references changes
azat
force-pushed
the
prewhere-filter-fix
branch
from
September 23, 2023 18:55
5eae132
to
24c0d53
Compare
nickitat
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix possible incorrect result with SimpleAggregateFunction in PREWHERE and FINAL
In case of FINAL the result of the expression for PREWHERE can be
changed after applying merge algorithm, and this is the problem for
SimpleAggregateFunction since after applying merging algorithm the value
can be changed.
Note, analyzer does not has this bug because it simply does not reuse columns from PREWHERE (they does not passed via
GlobalPlannerContext::createColumnIdentifier())