Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass http retry timeout as milliseconds #54438

Merged
merged 2 commits into from Sep 20, 2023
Merged

Pass http retry timeout as milliseconds #54438

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52dfaa5
pass http retry timeout as ms
canhld94 Sep 8, 2023
2a5b4ee
Merge branch 'master' into fix_http_timeout
canhld94 Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/IO/HTTPCommon.cpp
View file
Open in desktop
Expand Up @@ -321,7 +321,7 @@ namespace
/// To avoid such a deadlock we unlock `lock` before entering `pool_ptr->second->get`.
lock.unlock();

auto retry_timeout = timeouts.connection_timeout.totalMicroseconds();
auto retry_timeout = timeouts.connection_timeout.totalMilliseconds();
auto session = pool_ptr->second->get(retry_timeout);

setTimeouts(*session, timeouts);
Expand Down