Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix issues in accurateCastOrNull" #54472

Merged
merged 1 commit into from Sep 9, 2023

Conversation

alexey-milovidov
Copy link
Member

Reverts #54136

Fuzzer has found an issue, and I suspect this PR:

milovidov@milovidov-desktop:~$ clickhouse-local 
ClickHouse local version 23.9.1.1.

milovidov-desktop :) SELECT CAST(if(number % 2, 'truetrue', NULL), 'Nullable(Bool)') FROM numbers(1048577)

SELECT CAST(if(number % 2, 'truetrue', NULL), 'Nullable(Bool)')
FROM numbers(1048577)

Query id: 0f75e46b-15a2-4f90-bd9a-dff60b27a0d9

↑ Progress: 65.41 thousand rows, 523.27 KB (46.38 thousand rows/s., 371.08 KB/s.) ███████                                                                                                           6%
0 rows in set. Elapsed: 1.505 sec. Processed 65.41 thousand rows, 523.27 KB (43.46 thousand rows/s., 347.66 KB/s.)
Peak memory usage: 0.00 B.

Received exception:
Code: 49. DB::Exception: Invalid number of rows in Chunk column Nullable(UInt8) position 0: expected 65409, got 98113. (LOGICAL_ERROR)

milovidov-desktop :) Bye.

@alexey-milovidov
Copy link
Member Author

Smaller reproducer:

SELECT CAST(if(number % 2, 'truetrue', NULL), 'Nullable(Bool)') FROM numbers(2)

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Sep 9, 2023
@robot-ch-test-poll3
Copy link
Contributor

robot-ch-test-poll3 commented Sep 9, 2023

This is an automated comment for commit 71d37d6 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟡 pending

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success

@alexey-milovidov alexey-milovidov self-assigned this Sep 9, 2023
@alexey-milovidov
Copy link
Member Author

Yes, it helps.

@alexey-milovidov alexey-milovidov merged commit 3a0a5fc into master Sep 9, 2023
7 of 9 checks passed
@alexey-milovidov alexey-milovidov deleted the revert-54136-aiven-sal/fix_38585 branch September 9, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants