New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aggregate projections with normalized states #54480
Conversation
This is an automated comment for commit 667426f with description of existing statuses. It's updated for the latest CI running
|
|
src/Processors/QueryPlan/Optimizations/optimizeUseAggregateProjection.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good.
I would backport it at least into 23.8. |
Backport #54480 to 23.7: Fix aggregate projections with normalized states
Backport #54480 to 23.8: Fix aggregate projections with normalized states
Backport #54480 to 23.6: Fix aggregate projections with normalized states
Backport #54480 to 23.3: Fix aggregate projections with normalized states
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix incorrect aggregation projection optimization when using variant aggregate states. This optimization is accidentally enabled but not properly implemented, because after #39420 the comparison of DataTypeAggregateFunction is normalized. This fixes #54406