Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serialization of ColumnDecimal #54601

Merged
merged 2 commits into from Sep 14, 2023
Merged

Fix serialization of ColumnDecimal #54601

merged 2 commits into from Sep 14, 2023

Conversation

nickitat
Copy link
Member

@nickitat nickitat commented Sep 13, 2023 •
edited

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix serialization of ColumnDecimal.

Fixes: #54352

@robot-ch-test-poll2 robot-ch-test-poll2 added pr-bugfix Pull request with bugfix, not backported by default pr-status-⏳ PR with some pending statuses labels Sep 13, 2023
@robot-ch-test-poll2
Copy link
Contributor

robot-ch-test-poll2 commented Sep 13, 2023 •
edited by robot-clickhouse-ci-1

This is an automated comment for commit 9be779b with description of existing statuses. It's updated for the latest CI running

⏳ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
Mergeable CheckChecks if all other necessary checks are successful✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending

@novikd novikd self-assigned this Sep 13, 2023
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added pr-status-❌ PR with some error/faliure statuses and removed pr-status-⏳ PR with some pending statuses labels Sep 13, 2023
@alexey-milovidov alexey-milovidov merged commit b4f9d8a into ClickHouse:master Sep 14, 2023
4 of 5 checks passed
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added pr-status-⏳ PR with some pending statuses and removed pr-status-❌ PR with some error/faliure statuses labels Sep 14, 2023
@robot-clickhouse robot-clickhouse mentioned this pull request Sep 14, 2023
Merged
@robot-clickhouse robot-clickhouse mentioned this pull request Sep 14, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Sep 14, 2023
@robot-clickhouse
Backport #54601 to 23.8: Fix serialization of ColumnDecimal
3224384
@robot-clickhouse robot-clickhouse added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Sep 14, 2023
nickitat pushed a commit that referenced this pull request Sep 15, 2023
@robot-clickhouse
Backport #54601 to 23.8: Fix serialization of ColumnDecimal (#54625)
13a114d 
Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novikd novikd novikd approved these changes

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@novikd novikd

Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud pr-bugfix Pull request with bugfix, not backported by default pr-must-backport-cloud pr-status-⏳ PR with some pending statuses v23.8-must-backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assertion new_head == holder.key.data failed (Aggregator)
8 participants
@nickitat @robot-ch-test-poll2 @novikd @alexey-milovidov @robot-clickhouse @robot-ch-test-poll3 @robot-clickhouse-ci-1 @robot-clickhouse-ci-2