Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #54513 to 23.3: Fix possible parsing error in WithNames formats with disabled input_format_with_names_use_header #54633

Merged
merged 4 commits into from Sep 26, 2023

Conversation

robot-clickhouse-ci-1
Copy link
Contributor

Original pull-request #54513
Cherry-pick pull-request #54595

This pull-request is a last step of an automated backporting.
Treat it as a standard pull-request: look at the checks and resolve conflicts.
Merge it only if you intend to backport changes to the target branch, otherwise just close it.

…ats with disabled input_format_with_names_use_header
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backport Changes, backported to release branch. Do not use manually - automated use only! label Sep 14, 2023
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-status-✅ PR with only success statuses label Sep 14, 2023
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented Sep 14, 2023

This is an automated comment for commit 48b0d97 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure

@robot-ch-test-poll1 robot-ch-test-poll1 added pr-status-⏳ PR with some pending statuses and removed pr-status-✅ PR with only success statuses labels Sep 14, 2023
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added pr-status-❌ PR with some error/faliure statuses and removed pr-status-⏳ PR with some pending statuses labels Sep 14, 2023
@robot-ch-test-poll4 robot-ch-test-poll4 added pr-status-✅ PR with only success statuses and removed pr-status-❌ PR with some error/faliure statuses labels Sep 15, 2023
@robot-ch-test-poll3 robot-ch-test-poll3 added pr-status-⏳ PR with some pending statuses and removed pr-status-✅ PR with only success statuses labels Sep 15, 2023
@robot-clickhouse robot-clickhouse added pr-status-❌ PR with some error/faliure statuses and removed pr-status-⏳ PR with some pending statuses labels Sep 15, 2023
@robot-ch-test-poll robot-ch-test-poll added pr-status-✅ PR with only success statuses and removed pr-status-❌ PR with some error/faliure statuses labels Sep 20, 2023
@robot-ch-test-poll3 robot-ch-test-poll3 added pr-status-⏳ PR with some pending statuses and removed pr-status-✅ PR with only success statuses labels Sep 20, 2023
@robot-ch-test-poll4 robot-ch-test-poll4 added pr-status-❌ PR with some error/faliure statuses and removed pr-status-⏳ PR with some pending statuses labels Sep 20, 2023
@Avogar Avogar merged commit 87823a7 into 23.3 Sep 26, 2023
41 of 42 checks passed
@Avogar Avogar deleted the backport/23.3/54513 branch September 26, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backport Changes, backported to release branch. Do not use manually - automated use only! pr-status-❌ PR with some error/faliure statuses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants