New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s3-style URL fix #54931
s3-style URL fix #54931
Conversation
This is an automated comment for commit 2b95d13 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
@yariks5s, this is a new feature, not "not for changelog." |
src/IO/S3/URI.cpp
Outdated
@@ -18,6 +18,26 @@ | |||
namespace DB | |||
{ | |||
|
|||
struct UriConverter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
URI
src/IO/S3/URI.cpp
Outdated
uri.setHost(uri.getHost() + domain); | ||
} | ||
private: | ||
static constexpr auto S3_DOMAIN = ".s3.amazonaws.com"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a constant is used once, it's ok to have it inline, without a separate constant definition.
Need to add a test. |
By the way, we can merge the first version without config and add config in a subsequent PR. |
@yariks5s let's check - is it true that AWS SDK doesn't support s3-style URLs? |
Please check the test results. |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Allow S3-style URLs for table functions
s3
,gcs
,oss
. URL is automatically converted to HTTP. Example:'s3://clickhouse-public-datasets/hits.csv'
is converted to'https://clickhouse-public-datasets.s3.amazonaws.com/hits.csv'
Closes #31093.
Documentation entry for user-facing changes