New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix recalculation of skip indexes in ALTER UPDATE queries when table has adaptive granularity #55202
Fix recalculation of skip indexes in ALTER UPDATE queries when table has adaptive granularity #55202
Conversation
…granularity_bytes > 0 Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
Why do we need to rebuild projections when the granularity of parent part change? |
Yes, projections have no issue https://fiddle.clickhouse.com/379c0cc1-92de-47f2-a038-0aa90de07521 |
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks correct. But to be honest I already barely understand the code near recalculations of skip indexes and other dependencies. Probably we have to refactor it a bit in the future.
This is an automated comment for commit bea4a4e with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
The title and change log entry also need update. |
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
rebase and re-trigger CI
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
When table has adaptive granularity,
ALTER UPDATE
may change number of marks in compact parts.Reproduce: https://fiddle.clickhouse.com/9f2b67f0-07ab-4d90-82fa-5f2c1abf7ee7
Certainly close #53858, close #52652