Fix filtering by virtual columns with OR filter in query

[azat]

Changelog category (leave one):

• Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix filtering by virtual columns with OR filter in query (_part* filtering for MergeTree, _path/_file for various File/HDFS/... engines, _table for Merge)

The problem with the initial implementation #52653 was:

• OR can have multiple arguments

• It simply not correct to assume that if there are two arguments this is OK.
  Consider the following example:

  "WHERE (column_not_from_partition_by = 1) OR false OR false"

  Will be converted to:

  "WHERE false OR false"

And it will simply read nothing.

Yes, we could apply some optimization for bool, but this will not always
work, since to optimize things like "0 = 1" we need to execute it.

And the only way I see to handle this correctly (with ability to ignore
some expressions during filtering) is to make is_constant() function return
has it use something from the input block, so that we can be sure, that
we have something sensible, and not just "false".

Plus we cannot simply ignore the difference of the input and output
arguments of handling OR, we need to add always-true (1/true) if the
size is different, since otherwise it could break invariants (see
comment in the code).

P.S. analyzer does not have this bug, since it execute expression as
whole, and this is what filterBlockWithQuery() should do actually
instead, but this will be a more complex patch.

Fixes: #52653 (cc @alexey-milovidov )
Fixes: #54779 (cc @slanderous-mambo )
Fixes: #55288

[robot-clickhouse-ci-2]

This is an automated comment for commit 769ed2e with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
Bugfix validate check	Checks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker image for servers	The check to build and optionally push the mentioned image to docker hub	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Mergeable Check	Checks if all other necessary checks are successful	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
Push to Dockerhub	The check for building and pushing the CI related docker images to docker hub	✅ success
SQLTest	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	✅ success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style Check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

Check name	Description	Status
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	❌ failure
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	❌ failure

[den-crane]

probably it should fix #55288 as well

[azat]

Stateless tests (tsan) [5/5] — Tests are not finished, fail: 7, passed: 236, skipped: 1

• Fix data-race in kusto parser (in random generator) #55626

Stateless tests (release, DatabaseReplicated) [4/4] — fail: 1, passed: 1381, skipped: 23

• 00385_storage_file_and_clickhouse-local_app_long - Watching task /test/clickhouse/db/test_aqjmax9e/log/query-0000000016 is executing longer than distributed_ddl_task_timeout (=120) seconds - flaky

ClickHouse Integration Tests (tsan) [4/6] for PR #55418

• test_system_clusters_actual_information/test.py::test

Command:['docker-compose', '--env-file', '/ClickHouse/tests/integration/test_system_clusters_actual_information/_instances_0/.env', '--project-name', 'roottestsystemclustersactualinformation', '--file', '/ClickHouse/tests/integration/test_system_clusters_actual_information/_instances_0/node/docker-compose.yml', '--file', '/compose/docker_compose_keeper.yml', '--file', '/ClickHouse/tests/integration/test_system_clusters_actual_information/_instances_0/node_1/docker-compose.yml', 'pause', 'node_1']
Stderr:Pausing roottestsystemclustersactualinformation_node_1_1 ... 
Stderr:Pausing roottestsystemclustersactualinformation_node_1_1 ... error
Stderr:
Stderr:ERROR: for roottestsystemclustersactualinformation_node_1_1  Cannot pause container fb94f9669b2f675323d3716d8dd74db00299a8c314b25173d02d631fb312d447: OCI runtime pause failed: unable to freeze: unknown
Executing query SYSTEM RELOAD CONFIG on node

Interesting, docker compose pause does not have proper exit code, from docker logs:

time="2023-10-14T03:58:45.021444148Z" level=debug msg="FIXME: Got an API for which error does not match any expected type!!!: Cannot pause container fb94f9669b2f675323d3716d8dd74db00299a8c314b25173d02d631fb312d447: OCI runtime pause failed: unable to freeze: unknown" error_type="*errors.errorString" module=api
time="2023-10-14T03:58:45.021499520Z" level=error msg="Handler for POST /v1.42/containers/fb94f9669b2f675323d3716d8dd74db00299a8c314b25173d02d631fb312d447/pause returned error: Cannot pause container fb94f9669b2f675323d3716d8dd74db00299a8c314b25173d02d631fb312d447: OCI runtime pause failed: unable to freeze: unknown"
time="2023-10-14T03:58:45.021529070Z" level=debug msg="FIXME: Got an API for which error does not match any expected type!!!: Cannot pause container fb94f9669b2f675323d3716d8dd74db00299a8c314b25173d02d631fb312d447: OCI runtime pause failed: unable to freeze: unknown" error_type="*errors.errorString" module=api

Looks similar to moby/moby#35888, moby/moby#38877

Maybe some oddities in the env...

test_system_merges/test.py::test_mutation_simple[]
test_system_merges/test.py::test_mutation_simple[replicated]

• Fix flakiness of test_system_merges (by increasing sleep interval properly) #55627

Integration tests (release) [2/4] — fail: 2, passed: 596

test_system_merges/test.py::test_mutation_simple[]
test_system_merges/test.py::test_mutation_simple[replicated]

• Fix flakiness of test_system_merges (by increasing sleep interval properly) #55627

Integration tests (asan) [4/6] — fail: 2, passed: 412

test_system_merges/test.py::test_mutation_simple[]
test_system_merges/test.py::test_mutation_simple[replicated]

• Fix flakiness of test_system_merges (by increasing sleep interval properly) #55627

[azat]

Test failures looks unrelated now

[alexey-milovidov]

FIXME: Got an API for which error does not match any expected type!!!

Is it possible to replace Docker with Podman?

[azat]

Is it possible to replace Docker with Podman?

AFAIR I thought about this and it wasn't that easy, and you are right - likely it can be fixed that way (even though they use some common libraries unlikely this could be related in this particular case), but it also can have some podman-related issues that will pops up in CI.

Maybe it will be simpler to find the problem in the docker itself, or maybe updating it will be enough...

[antonio2368]

@azat it looks like test_system_merges failures were related, it's consistently failing after this PR was merged

[alexey-milovidov]

Revert it.

[azat]

@antonio2368 you are right.

That was over optimistic from my side to assume that my fix for this test #55627 addresses this problems, however the problem was completely different, since after my patch x OR 1 simply does not execute x, and so sleep did not even executed.

So I've resubmitted it here - #55678 with a fix for the test.

Also note, that this PR had been already backported, while your revert had not, so you need to apply only the test hunk from the resubmit (and to avoid conflicts you need to apply #55627 first).