Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove existing moving/ dir if allow_remove_stale_moving_parts is off #55480

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Remove existing moving/ dir if allow_remove_stale_moving_parts is off #55480

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06f3b82
remove moving/ dir if allow_remove_stale_ is off
myrrc Oct 10, 2023
b634711
Update src/Storages/MergeTree/MergeTreePartsMover.cpp
vdimir Oct 11, 2023
d3f9145
Update src/Storages/MergeTree/MergeTreePartsMover.cpp
vdimir Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/Storages/MergeTree/MergeTreePartsMover.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,10 +229,16 @@ MergeTreePartsMover::TemporaryClonedPart MergeTreePartsMover::clonePart(const Me
String relative_path = part->getDataPartStorage().getPartDirectory();
if (disk->exists(path_to_clone + relative_path))
{
throw Exception(ErrorCodes::DIRECTORY_ALREADY_EXISTS,
"Cannot clone part {} from '{}' to '{}': path '{}' already exists",
part->name, part->getDataPartStorage().getDiskName(), disk->getName(),
// If setting is on, we should've already cleaned moving/ dir on startup
if (data->allowRemoveStaleMovingParts())
throw Exception(ErrorCodes::DIRECTORY_ALREADY_EXISTS,
"Cannot clone part {} from '{}' to '{}': path '{}' already exists",
part->name, part->getDataPartStorage().getDiskName(), disk->getName(),
fullPath(disk, path_to_clone + relative_path));

LOG_WARNING(log, "Path {} already exists. Will remove it and clone again",
vdimir marked this conversation as resolved.
Show resolved Hide resolved
fullPath(disk, path_to_clone + relative_path));
disk->removeRecursive(fs::path(path_to_clone) / relative_path / "");
}

disk->createDirectories(path_to_clone);
Expand Down