Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce setting date_time_overflow_behavior to control the overflow behavior when converting to Date / Date32 / DateTime / DateTime64 #55696

Merged
merged 8 commits into from Oct 27, 2023

Conversation

zvonand
Copy link
Contributor

@zvonand zvonand commented Oct 16, 2023

Closes #51402, #39249.

This is a better version of #40217.

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Introduced setting date_time_overflow_behavior with possible values ignore, throw, saturate that controls the overflow behavior when converting from Date, Date32, DateTime64, Integer or Float to Date, Date32, DateTime or DateTime64.

@zvonand
Copy link
Contributor Author

zvonand commented Oct 16, 2023

Current behavior is left as default, but the behavior itself is not very good.
For instance, some functions are declared monotonic, but in some cases they aren't saturated -> they are not monotonic.

@Avogar Avogar added the can be tested Allows running workflows for external contributors label Oct 17, 2023
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-feature Pull request with new product feature label Oct 17, 2023
@robot-clickhouse-ci-2
Copy link
Contributor

robot-clickhouse-ci-2 commented Oct 17, 2023

This is an automated comment for commit 2da12ec with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Docs CheckBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@zvonand zvonand force-pushed the zvonand-datetime-ranges branch 6 times, most recently from 00a4fc6 to a84e6dd Compare October 20, 2023 13:34
@zvonand zvonand marked this pull request as ready for review October 20, 2023 13:55
@zvonand zvonand force-pushed the zvonand-datetime-ranges branch 3 times, most recently from b62db6f to 1f81cce Compare October 22, 2023 10:12
@rschu1ze rschu1ze self-assigned this Oct 22, 2023
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added pr-improvement Pull request with some product improvements and removed pr-feature Pull request with new product feature labels Oct 22, 2023
docs/en/operations/settings/settings.md Outdated Show resolved Hide resolved
docs/en/operations/settings/settings.md Outdated Show resolved Hide resolved
docs/en/operations/settings/settings.md Outdated Show resolved Hide resolved
docs/en/operations/settings/settings.md Outdated Show resolved Hide resolved
src/Core/Settings.h Outdated Show resolved Hide resolved
src/Functions/DateTimeTransforms.h Outdated Show resolved Hide resolved
src/Functions/DateTimeTransforms.h Outdated Show resolved Hide resolved
src/Functions/DateTimeTransforms.h Show resolved Hide resolved
src/Functions/FunctionsConversion.h Outdated Show resolved Hide resolved
src/Functions/DateTimeTransforms.h Show resolved Hide resolved
@rschu1ze rschu1ze changed the title Introduce setting to control overflow when converting Date / Date32 / DateTime / DateTime64 Introduce setting date_time_overflow_mode to control the overflow behavior when converting to Date / Date32 / DateTime / DateTime64 Oct 22, 2023
@rschu1ze

This comment was marked as resolved.

@zvonand

This comment was marked as resolved.

@zvonand zvonand force-pushed the zvonand-datetime-ranges branch 2 times, most recently from 6f4d5fb to 014babb Compare October 23, 2023 23:49
@zvonand zvonand requested a review from rschu1ze October 24, 2023 00:06
docs/en/operations/settings/settings.md Outdated Show resolved Hide resolved
src/Functions/FunctionsConversion.h Outdated Show resolved Hide resolved
throw Exception{ErrorCodes::VALUE_IS_OUT_OF_RANGE_OF_DATA_TYPE,
"Input value {} of a column \"{}\" is out of allowed Date32 range, which is [{}, {}]", days_num, column_name, DAYNUM_OFFSET_EPOCH, DATE_LUT_MAX_EXTEND_DAY_NUM};
{
if (date_time_overflow_mode == FormatSettings::DateTimeOverflowMode::Saturate)
Copy link
Member

@rschu1ze rschu1ze Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Sorry, I know I asked before but should we replace the if by a switch?

  2. If the mode is ignore, we'll throw an exception. That doesn't sound right. EDIT: I think you wanted to preserve the previous behavior which was throw and therefore different from the setting default value ignore. So that's okay then, but please let's add a comment to not confuse future readers of the code.

Copy link
Contributor Author

@zvonand zvonand Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Yes, here it is fine to replace it
  2. Comment added

baibaichen added a commit to baibaichen/gluten that referenced this pull request Dec 2, 2023
baibaichen added a commit to baibaichen/gluten that referenced this pull request Dec 6, 2023
baibaichen added a commit to baibaichen/gluten that referenced this pull request Dec 8, 2023
baibaichen added a commit to baibaichen/gluten that referenced this pull request Dec 11, 2023
baibaichen added a commit to baibaichen/gluten that referenced this pull request Dec 13, 2023
baibaichen added a commit to baibaichen/gluten that referenced this pull request Dec 13, 2023
baibaichen added a commit to baibaichen/gluten that referenced this pull request Dec 16, 2023
baibaichen added a commit to baibaichen/gluten that referenced this pull request Dec 16, 2023
baibaichen added a commit to baibaichen/gluten that referenced this pull request Dec 18, 2023
baibaichen added a commit to baibaichen/gluten that referenced this pull request Dec 26, 2023
baibaichen added a commit to baibaichen/gluten that referenced this pull request Dec 29, 2023
baibaichen added a commit to baibaichen/gluten that referenced this pull request Jan 9, 2024
baibaichen added a commit to baibaichen/gluten that referenced this pull request Jan 10, 2024
baibaichen added a commit to baibaichen/gluten that referenced this pull request Jan 11, 2024
baibaichen added a commit to baibaichen/gluten that referenced this pull request Jan 12, 2024
baibaichen added a commit to baibaichen/gluten that referenced this pull request Jan 18, 2024
baibaichen added a commit to baibaichen/gluten that referenced this pull request Jan 19, 2024
baibaichen added a commit to baibaichen/gluten that referenced this pull request Jan 21, 2024
baibaichen added a commit to baibaichen/gluten that referenced this pull request Jan 22, 2024
baibaichen added a commit to baibaichen/gluten that referenced this pull request Jan 23, 2024
baibaichen added a commit to baibaichen/gluten that referenced this pull request Jan 24, 2024
baibaichen added a commit to baibaichen/gluten that referenced this pull request Jan 26, 2024
baibaichen added a commit to baibaichen/gluten that referenced this pull request Jan 28, 2024
baibaichen added a commit to baibaichen/gluten that referenced this pull request Jan 29, 2024
baibaichen added a commit to baibaichen/gluten that referenced this pull request Jan 31, 2024
baibaichen added a commit to baibaichen/gluten that referenced this pull request Feb 2, 2024
baibaichen added a commit to baibaichen/gluten that referenced this pull request Feb 2, 2024
baibaichen added a commit to baibaichen/gluten that referenced this pull request Feb 2, 2024
baibaichen added a commit to baibaichen/gluten that referenced this pull request Feb 4, 2024
baibaichen added a commit to baibaichen/gluten that referenced this pull request Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements
Projects
None yet
4 participants