Cherry pick #55678 to 23.9: Fix filtering by virtual columns with OR filter in query (resubmit) #55755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem with the initial implementation #52653 was: - OR can have multiple arguments - It simply not correct to assume that if there are two arguments this is OK. Consider the following example: "WHERE (column_not_from_partition_by = 1) OR false OR false" Will be converted to: "WHERE false OR false" And it will simply read nothing. Yes, we could apply some optimization for bool, but this will not always work, since to optimize things like "0 = 1" we need to execute it. And the only way to make handle this correctly (with ability to ignore some commands during filtering) is to make is_constant() function return has it use something from the input block, so that we can be sure, that we have some sensible, and not just "false". Plus we cannot simply ignore the difference of the input and output arguments of handling OR, we need to add always-true (1/true) if the size is different, since otherwise it could break invariants (see comment in the code). This includes (but not limited to): - _part* filtering for MergeTree - _path/_file for various File/HDFS/... engines - _table for Merge - ... P.S. analyzer does not have this bug, since it execute expression as whole, and this is what filterBlockWithQuery() should do actually instead, but this will be a more complex patch. Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com> (cherry picked from commit b107712)
After the previous patch "x OR 1" will not execute "x", and because of this test_system_merges::test_mutation_simple started to fail since "sleep" function did not executed. Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Fix filtering by virtual columns with OR filter in query (resubmit)
robot-ch-test-poll3
added
pr-cherrypick
…af7d3cf0ceb3af619fb45962a09
robot-clickhouse-ci-2
deleted the
cherrypick/23.9/79eccfb6421eeaf7d3cf0ceb3af619fb45962a09
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original pull-request #55678
This pull-request is a first step of an automated backporting.
It contains changes like after calling a local command
git cherry-pick.If you intend to continue backporting this changes, then resolve all conflicts if any.
Otherwise, if you do not want to backport them, then just close this pull-request.
The check results does not matter at this step - you can safely ignore them.
Note
This pull-request will be merged automatically as it reaches the mergeable state, do not merge it manually.
If the PR was closed and then reopened
If it stuck, check #55678 for
pr-backports-createdand delete it if necessary. Manually merging will do nothing, sincepr-backports-createdprevents the original PR #55678 from being processed.If you want to recreate the PR: delete the
pr-cherrypicklabel and delete this branch.You may also need to delete the
pr-backports-createdlabel from the original PR.