Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One final leftover in diff_urls of PRInfo #55874

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

Felixoid
Copy link
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

The default branch is not always master, and this is the case for https://github.com/ClickHouse/clickhouse-docs/actions/runs/6589156162/job/17902978407. Here we use the proper default branch, and get rid of the last appearance of diff_url

@Felixoid Felixoid requested a review from maxknv October 20, 2023 15:25
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Oct 20, 2023
@robot-ch-test-poll2
Copy link
Contributor

robot-ch-test-poll2 commented Oct 20, 2023

This is an automated comment for commit 849e441 with description of existing statuses. It's updated for the latest CI running

⏳ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending

@Felixoid
Copy link
Member Author

The main thing is already checked here and in ClickHouse/clickhouse-docs#1513, so I cancel the workflow

@maxknv
Copy link
Member

maxknv commented Oct 20, 2023

LGTM, thanks!

@Felixoid Felixoid merged commit 6a37546 into master Oct 20, 2023
17 of 157 checks passed
@Felixoid Felixoid deleted the universal-diff-urls branch October 20, 2023 15:49
@Felixoid Felixoid added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Oct 20, 2023
robot-clickhouse-ci-1 added a commit that referenced this pull request Oct 20, 2023
…105bb6394b6e75b6a43e2eab55426

Cherry pick #55874 to 23.3: One final leftover in diff_urls of PRInfo
robot-clickhouse-ci-1 added a commit that referenced this pull request Oct 20, 2023
…105bb6394b6e75b6a43e2eab55426

Cherry pick #55874 to 23.7: One final leftover in diff_urls of PRInfo
robot-clickhouse-ci-1 added a commit that referenced this pull request Oct 20, 2023
…105bb6394b6e75b6a43e2eab55426

Cherry pick #55874 to 23.8: One final leftover in diff_urls of PRInfo
robot-clickhouse-ci-1 added a commit that referenced this pull request Oct 20, 2023
…105bb6394b6e75b6a43e2eab55426

Cherry pick #55874 to 23.9: One final leftover in diff_urls of PRInfo
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Oct 20, 2023
Felixoid added a commit that referenced this pull request Oct 20, 2023
Backport #55874 to 23.3: One final leftover in diff_urls of PRInfo
Felixoid added a commit that referenced this pull request Oct 20, 2023
Backport #55874 to 23.7: One final leftover in diff_urls of PRInfo
Felixoid added a commit that referenced this pull request Oct 20, 2023
Backport #55874 to 23.9: One final leftover in diff_urls of PRInfo
Felixoid added a commit that referenced this pull request Oct 20, 2023
Backport #55874 to 23.8: One final leftover in diff_urls of PRInfo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants