-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: StorageNull supports subcolumns #55912
Merged
Avogar
merged 3 commits into
ClickHouse:master
from
wxybear:fix/storage_null_supports_subcolumns
Oct 24, 2023
Merged
fix: StorageNull supports subcolumns #55912
Avogar
merged 3 commits into
ClickHouse:master
from
wxybear:fix/storage_null_supports_subcolumns
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evillique
added
the
can be tested
Allows running workflows for external contributors
label
Oct 22, 2023
This is an automated comment for commit 015d041 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
Thanks for the fix! Can you please add a test? You can check 00557_alter_null_storage_tables as an example. |
robot-ch-test-poll1
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Oct 23, 2023
@Avogar Thanks! I commited a simple test. |
Avogar
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-bugfix
Pull request with bugfix, not backported by default
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix reading subcolumns from StorageNull. Previously it was possible to create a table with engine Null with subcolumns, but it was not possible to select these columns.
Closes #55785