WindowTransform decrease amount of virtual function calls

[kitaisreal]

Changelog category (leave one):

• Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

WindowTransform decrease amount of virtual function calls.

[kitaisreal]

Prepare data:

CREATE TABLE test_table (id UInt64, value UInt64) ENGINE=MergeTree ORDER BY id;
INSERT INTO test_table SELECT number, number FROM numbers_mt(150000000);

Before:

SELECT id, sum(value) OVER test_window, min(value) OVER test_window, max(value) OVER test_window, avg(value) OVER test_window FROM test_table WINDOW test_window AS (PARTITION BY id % 25) FORMAT Null

0 rows in set. Elapsed: 9.767 sec. Processed 150.00 million rows, 2.40 GB (15.36 million rows/s., 245.74 MB/s.)
Peak memory usage: 2.69 GiB.

After:

SELECT id, sum(value) OVER test_window, min(value) OVER test_window, max(value) OVER test_window, avg(value) OVER test_window FROM test_table WINDOW test_window AS (PARTITION BY id % 25) FORMAT Null

0 rows in set. Elapsed: 8.429 sec. Processed 150.00 million rows, 2.40 GB (17.80 million rows/s., 284.74 MB/s.)
Peak memory usage: 2.67 GiB.

Before:

SELECT id, sum(value) OVER test_window, min(value) OVER test_window, max(value) OVER test_window, avg(value) OVER test_window FROM test_table WINDOW test_window AS (PARTITION BY id % 5) FORMAT Null

0 rows in set. Elapsed: 9.784 sec. Processed 150.00 million rows, 2.40 GB (15.33 million rows/s., 245.31 MB/s.)
Peak memory usage: 3.76 GiB.

After:

SELECT id, sum(value) OVER test_window, min(value) OVER test_window, max(value) OVER test_window, avg(value) OVER test_window FROM test_table WINDOW test_window AS (PARTITION BY id % 5) FORMAT Null

0 rows in set. Elapsed: 8.456 sec. Processed 150.00 million rows, 2.40 GB (17.74 million rows/s., 283.84 MB/s.)
Peak memory usage: 3.77 GiB.

[robot-ch-test-poll1]

This is an automated comment for commit e533abe with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker image for servers	The check to build and optionally push the mentioned image to docker hub	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Mergeable Check	Checks if all other necessary checks are successful	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
Push to Dockerhub	The check for building and pushing the CI related docker images to docker hub	✅ success
SQLTest	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	✅ success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Style Check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

Check name	Description	Status
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	❌ failure
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	❌ failure
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	❌ failure

[Algunenano]

I guess a similar improvement might be possible in other places where insertMergeResultInto is called in a non constexpr environment right? I see FunctionInitializeAggregation and FunctionArrayReduce

[Algunenano]

Adding a commit improving:

• FunctionInitializeAggregation -> Select initializeAggregation('uniqExact', number) from numbers(100_000_000) settings max_threads=1 format Null; around 20% faster
• ArrayReduce: Less improvement, around 10% on a query like: Select arrayReduce('sum', a) from a settings max_threads=1 format Null;

@kitaisreal WDYT?

[kitaisreal]

Yes, make sense. We need to merge this.

[Algunenano]

01572_kill_window_function became flaky because the query used there became thousands of times faster (from not finishing after 50 seconds when I got tired of waiting to finishing in 50ms). It should be better now

[Algunenano]

• Integration tests (tsan) [4/6] — fail: 1, passed: 421 -> test_system_clusters_actual_information/test.py::test -> Flaky test_system_clusters_actual_information #55168
• Integration tests (tsan) [5/6] — fail: 1, passed: 542 -> test_ttl_move/test.py::test_alter_with_merge_work[mt_work] -> test_ttl_move/test.py::test_alter_with_merge_work is flaky #56686
• Stateless tests (aarch64) — fail: 1, passed: 5822, skipped: 30 -> 00002_log_and_exception_messages_formatting. Currently flaky too
• Stress test (debug) — Check timeout expired -> The server took too long to shutdown. Not sure why