New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "Add function arrayRandomSample()"" #56416
Merged
rschu1ze
merged 9 commits into
ClickHouse:master
from
rschu1ze:arrayRandomSample-improved
Nov 8, 2023
Merged
Revert "Revert "Add function arrayRandomSample()"" #56416
rschu1ze
merged 9 commits into
ClickHouse:master
from
rschu1ze:arrayRandomSample-improved
Nov 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e47e50e.
CREATE TABLE tab (col Array(String)) ENGINE = MergeTree ORDER BY col; INSERT INTO tab VALUES (['a', 'b', 'c']) (['d', 'e']) (['f', 'g', 'h']); SELECT arrayRandomSample(col, 2) FROM tab; Previous result: ['a', 'c'] ['a', 'c'] ['a', 'c'] Now: ['b', 'c'] ['e', 'd'] ['f', 'h']
This is an automated comment for commit 66800a3 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
alexey-milovidov
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53098
Reverts the revert #56399 and additionally:
index
vector out of the loop (1). (7223d49)try/catch
(e09f596)(1) and (2) improved runtimes from 13 minutes to 1.2 sec when doing:
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added a new SQL function, "arrayRandomSample(arr, k)" which returns a sample of k elements from the input array. Similar functionality could previously be achieved only with less convenient syntax, e.g. "SELECT arrayReduce('groupArraySample(3)', range(10))".