New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query cache: Allow to ignore non-deterministic queries #56519
Merged
rschu1ze
merged 5 commits into
ClickHouse:master
from
rschu1ze:qc-ignore-nondeterministic-queries
Nov 13, 2023
Merged
Query cache: Allow to ignore non-deterministic queries #56519
rschu1ze
merged 5 commits into
ClickHouse:master
from
rschu1ze:qc-ignore-nondeterministic-queries
Nov 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll3
added
the
pr-improvement
Pull request with some product improvements
label
Nov 9, 2023
This is an automated comment for commit 7864df4 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
kssenii
approved these changes
Nov 9, 2023
rschu1ze
force-pushed
the
qc-ignore-nondeterministic-queries
branch
from
November 12, 2023 15:12
c6f5e4f
to
bea529c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56504
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Setting
query_cache_store_results_of_queries_with_nondeterministic_functions
(with valuesfalse
ortrue
) was marked obsolete. It was replaced by settingquery_cache_nondeterministic_function_handling
, a three-valued enum that controls how the query cache handles queries with non-deterministic functions: a) throw an exception (default behavior), b) save the non-deterministic query result regardless, or c) ignore, i.e. don't throw an exception and don't cache the result.