Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite equality with is null check in JOIN ON section #56538

Merged
merged 6 commits into from Nov 21, 2023

Conversation

vdimir
Copy link
Member

@vdimir vdimir commented Nov 9, 2023

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Rewrite equality with is null check in JOIN ON section. Analyzer only
SET allow_experimental_analyzer = 1;
SELECT * FROM t1 JOIN t2 ON a = b OR (a IS NULL AND b IS NULL)

will be transformed into

SELECT * FROM t1 JOIN t2 ON a <=> b

It provides better compatibility with BI tools.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@robot-ch-test-poll robot-ch-test-poll added the pr-feature Pull request with new product feature label Nov 9, 2023
@robot-ch-test-poll
Copy link
Contributor

robot-ch-test-poll commented Nov 9, 2023

This is an automated comment for commit 06c6282 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

@vdimir vdimir force-pushed the vdimir/join_on_nullsafe_optimization branch from b5ef6e2 to b726455 Compare November 9, 2023 18:39
Copy link

clickhouse-ci bot commented Nov 9, 2023

This is an automatic comment. The PR descriptions does not match the template.

Please, edit it accordingly.

The error is: Category 'Performance Optimization' is not valid

@alexey-milovidov alexey-milovidov removed the pr-feature Pull request with new product feature label Nov 9, 2023
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-performance Pull request with some performance improvements label Nov 10, 2023
@vdimir vdimir force-pushed the vdimir/join_on_nullsafe_optimization branch from 4de15e3 to b3d06ef Compare November 15, 2023 17:02
@vdimir
Copy link
Member Author

vdimir commented Nov 15, 2023

I changed changelog entry from Performance Improvement back to Improvement because such expressions in JOIN ON was not supported at all and PR adds possibility to execute such a query, so it doesn't improve a query execution speed.
And in SELECT expression we don't support <=> operator, so no change there.

@vdimir vdimir changed the title Optimize equality with is null check in JOIN ON section Rewrite equality with is null check in JOIN ON section Nov 15, 2023
@vdimir vdimir force-pushed the vdimir/join_on_nullsafe_optimization branch from b3d06ef to 6ad0e90 Compare November 16, 2023 10:31
@robot-ch-test-poll robot-ch-test-poll added pr-improvement Pull request with some product improvements and removed pr-performance Pull request with some performance improvements labels Nov 16, 2023
@vdimir vdimir merged commit 8f34b36 into master Nov 21, 2023
335 of 339 checks passed
@vdimir vdimir deleted the vdimir/join_on_nullsafe_optimization branch November 21, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants