Well known protos

[antaljanosbenjamin]

Changelog category (leave one):

• Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add support for the well-known Protobuf types in the Protobuf format.

Documentation entry for user-facing changes

• Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

[robot-ch-test-poll4]

This is an automated comment for commit adf21e3 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker image for servers	The check to build and optionally push the mentioned image to docker hub	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Mergeable Check	Checks if all other necessary checks are successful	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
Push to Dockerhub	The check for building and pushing the CI related docker images to docker hub	✅ success
SQLTest	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	✅ success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style Check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

Check name	Description	Status
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	❌ failure
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	❌ failure

[Felixoid]

> dpkg-deb -c clickhouse-common-static_23.11.1.1024_amd64.deb 
drwxr-xr-x root/root         0 2023-11-15 15:14 ./usr/
drwxr-xr-x root/root         0 2023-11-15 15:14 ./usr/bin/
-rwxr-xr-x root/root 502549664 2023-11-15 15:12 ./usr/bin/clickhouse
-rwxr-xr-x root/root  20115202 2023-11-15 15:13 ./usr/bin/clickhouse-diagnostics
l--------- 0/0               0 2023-11-15 15:12 ./usr/bin/clickhouse-extract-from-config -> clickhouse
-rwxr-xr-x root/root 194059984 2023-11-15 15:00 ./usr/bin/clickhouse-library-bridge
-rwxr-xr-x root/root 194772296 2023-11-15 15:00 ./usr/bin/clickhouse-odbc-bridge
drwxr-xr-x root/root         0 2023-11-15 15:14 ./usr/share/
drwxr-xr-x root/root         0 2023-11-15 15:14 ./usr/share/bash-completion/
drwxr-xr-x root/root         0 2023-11-15 15:14 ./usr/share/bash-completion/completions/
-rw-r--r-- root/root       959 2023-11-15 14:41 ./usr/share/bash-completion/completions/clickhouse
-rw-r--r-- root/root       154 2023-11-15 14:41 ./usr/share/bash-completion/completions/clickhouse-benchmark
-rw-r--r-- root/root      5490 2023-11-15 14:41 ./usr/share/bash-completion/completions/clickhouse-bootstrap
-rw-r--r-- root/root       151 2023-11-15 14:41 ./usr/share/bash-completion/completions/clickhouse-client
-rw-r--r-- root/root       150 2023-11-15 14:41 ./usr/share/bash-completion/completions/clickhouse-local
drwxr-xr-x root/root         0 2023-11-15 15:14 ./usr/share/clickhouse/
drwxr-xr-x root/root         0 2023-11-15 15:14 ./usr/share/clickhouse/proto/
drwxr-xr-x root/root         0 2023-11-15 15:14 ./usr/share/clickhouse/proto/google/
drwxr-xr-x root/root         0 2023-11-15 15:14 ./usr/share/clickhouse/proto/google/protobuf/
-rw-r--r-- root/root      5909 2023-11-15 14:42 ./usr/share/clickhouse/proto/google/protobuf/any.proto
-rw-r--r-- root/root      7734 2023-11-15 14:42 ./usr/share/clickhouse/proto/google/protobuf/api.proto
-rw-r--r-- root/root     38497 2023-11-15 14:42 ./usr/share/clickhouse/proto/google/protobuf/descriptor.proto
-rw-r--r-- root/root      4895 2023-11-15 14:42 ./usr/share/clickhouse/proto/google/protobuf/duration.proto
-rw-r--r-- root/root      2363 2023-11-15 14:42 ./usr/share/clickhouse/proto/google/protobuf/empty.proto
-rw-r--r-- root/root      8185 2023-11-15 14:42 ./usr/share/clickhouse/proto/google/protobuf/field_mask.proto
-rw-r--r-- root/root      2341 2023-11-15 14:42 ./usr/share/clickhouse/proto/google/protobuf/source_context.proto
-rw-r--r-- root/root      3779 2023-11-15 14:42 ./usr/share/clickhouse/proto/google/protobuf/struct.proto
-rw-r--r-- root/root      6459 2023-11-15 14:42 ./usr/share/clickhouse/proto/google/protobuf/timestamp.proto
-rw-r--r-- root/root      6126 2023-11-15 14:42 ./usr/share/clickhouse/proto/google/protobuf/type.proto
-rw-r--r-- root/root      4042 2023-11-15 14:42 ./usr/share/clickhouse/proto/google/protobuf/wrappers.proto
drwxr-xr-x root/root         0 2023-11-15 15:14 ./usr/share/doc/
drwxr-xr-x root/root         0 2023-11-15 15:14 ./usr/share/doc/clickhouse-common-static/
-rw-rw-r-- root/root       203 2023-11-15 14:41 ./usr/share/doc/clickhouse-common-static/AUTHORS
-rw-rw-r-- root/root    401959 2023-11-15 14:41 ./usr/share/doc/clickhouse-common-static/CHANGELOG.md
-rw-rw-r-- root/root     11389 2023-11-15 14:41 ./usr/share/doc/clickhouse-common-static/LICENSE
-rw-rw-r-- root/root      4446 2023-11-15 14:41 ./usr/share/doc/clickhouse-common-static/README.md

Looks good!

[antaljanosbenjamin]

Test failures:

• Integration tests (asan) [4/4] Flaky test_system_clusters_actual_information #55168
• Stateless tests (release, analyzer)
  • 01600_parts_states_metrics_long Add back flaky tests to analyzer_tech_debt.txt #57307
  • 01238_http_memory_tracking flaky 01238_http_memory_tracking is flaky #57316

[Felixoid]

Unfortunately, I don't get the improvements, so it's good from the packaging perspective.

For the code, I think it's the best to get another approval