New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not allow creating replicated table with inconsistent merge params #56833
Do not allow creating replicated table with inconsistent merge params #56833
Conversation
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
Not implement for graphite merge tree yet. My idea for graphite merge tree is to save as 128 sip hash value of graphite config in zookeeper. Any better idea is appreciated. |
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
This is an automated comment for commit 9ff7e12 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
Kindly remind @tavplubix [THANKS] |
auto * current_pos = buf.position(); | ||
for (; *s; ++s) | ||
{ | ||
if (buf.eof() || *buf.position() != *s) | ||
{ | ||
buf.position() = current_pos; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unsafe to use a previously saved position after checking for eof, because eof()
might call nextImpl()
which might refill the buffer with a new bunch of data or even reallocate the buffer. See PeekableReadBuffer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because eof() might call nextImpl() which might refill the buffer with a new bunch of data or even reallocate the buffer
Yes, I'm aware of this so I only implement peekString
for ReadBufferFromString
. But now look at ReadBufferFromString
code seem it doesn't work as I thought, still have internal buffer. Then this implementation is incorrect.
Co-authored-by: Alexander Tokmakov <tavplubix@gmail.com>
- peekString doesn't always work even for ReadBufferFromString - more comment re. backward compatibility Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
See #56724 (comment)