Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tryBase64Decode() with invalid input #56913

Merged
merged 1 commit into from Nov 18, 2023

Conversation

rschu1ze
Copy link
Member

@rschu1ze rschu1ze commented Nov 17, 2023

See #54119 (comment)

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Function tryBase64Decode() now returns an empty string instead of garbage if the input is invalid, e.g. SELECT tryBase64Decode('aoeo054640eu='); (note the padding character = at the end which corrupts the base64 value). This makes the function behavior consistent with the behavior that has been documented for many years. At the same time, this marks an incompatibility with the previously incorrect function behavior.

@robot-ch-test-poll robot-ch-test-poll added the pr-bugfix Pull request with bugfix, not backported by default label Nov 17, 2023
@robot-ch-test-poll
Copy link
Contributor

robot-ch-test-poll commented Nov 17, 2023

This is an automated comment for commit b2dc5ad with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
Bugfix validate checkChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure

@alexey-milovidov alexey-milovidov self-assigned this Nov 17, 2023
@rschu1ze
Copy link
Member Author

Backward compatibility test failed as expected, I updated the changelog entry.

@rschu1ze rschu1ze merged commit 7a99497 into ClickHouse:master Nov 18, 2023
332 of 338 checks passed
@rschu1ze rschu1ze added the pr-backward-incompatible Pull request with backwards incompatible changes label Nov 18, 2023
@zvonand
Copy link
Contributor

zvonand commented Nov 19, 2023

test_backward_compatibility/test_functions.py::test_string_functions is failing all the way after this PR, also in master. Is this OK?

@rschu1ze
Copy link
Member Author

test_backward_compatibility/test_functions.py::test_string_functions is failing all the way after this PR, also in master. Is this OK?

Nope, fix: #56975

mahak pushed a commit to mahak/ClickHouse that referenced this pull request Nov 19, 2023
…rd_compat

Add exclude for tryBase64Decode to backward compat test (follow-up to ClickHouse#56913)
@tavplubix
Copy link
Member

@rschu1ze, please check failed tests before merging. Even if failures seem to be unrelated to changes, they must be debugged anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backward-incompatible Pull request with backwards incompatible changes pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants