New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tryBase64Decode()
with invalid input
#56913
Fix tryBase64Decode()
with invalid input
#56913
Conversation
This is an automated comment for commit b2dc5ad with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
Backward compatibility test failed as expected, I updated the changelog entry. |
|
…rd_compat Add exclude for tryBase64Decode to backward compat test (follow-up to ClickHouse#56913)
@rschu1ze, please check failed tests before merging. Even if failures seem to be unrelated to changes, they must be debugged anyway |
See #54119 (comment)
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Function
tryBase64Decode()
now returns an empty string instead of garbage if the input is invalid, e.g.SELECT tryBase64Decode('aoeo054640eu=');
(note the padding character=
at the end which corrupts the base64 value). This makes the function behavior consistent with the behavior that has been documented for many years. At the same time, this marks an incompatibility with the previously incorrect function behavior.