Fix build in Backups/BackupIO_S3.cpp

[rschu1ze]

PR #56460 broke the build:

/home/ubuntu/repo/ClickHouse/src/Backups/BackupIO_S3.cpp:255:5: error: no matching function for call to 'copyS3File'
  255 |     copyS3File(
      |     ^~~~~~~~~~
/home/ubuntu/repo/ClickHouse/src/IO/S3/copyS3File.h:31:6: note: candidate function not viable: no known conversion from 'std::shared_ptr<S3::Client>' to 'const String' (aka 'const basic_string<char, char_traits<char>, allocator<char>>') for 2nd argument
   33 | void copyS3File(
      |      ^
   34 |     const std::shared_ptr<const S3::Client> & s3_client,
   35 |     const String & src_bucket,
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
[10301/12493] Building CXX object src/CMakeFiles/dbms.dir/Functions/CastOverloadResolver.cpp.o
ninja: build stopped: subcommand failed.

Changelog category (leave one):

• Not for changelog (changelog entry is not required)

[robot-ch-test-poll2]

This is an automated comment for commit 60a17ee with description of existing statuses. It's updated for the latest CI running

⏳ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
Mergeable Check	Checks if all other necessary checks are successful	✅ success
Push to Dockerhub	The check for building and pushing the CI related docker images to docker hub	✅ success

Check name	Description	Status
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending

[antonio2368]

PR #56460 broke the build:

Actually it's this PR #56314 which modifies copyS3File
It didn't have the latest master so it didn't catch the new code that calls copyS3File

This is an interesting problem and I don't have an idea how to avoid such situations. Maybe we can require for a build with latest master before accepting a merge but I think that would simply make things more annoying so manual fixes in such rare cases make more sense.

[rschu1ze]

Agree. Afais, there are physical merge conflicts ever 1-2 weeks which is rarely given the amount of changes that go into master. Fixing them ad hoc seems better than wasting resources in a extra build that would also not find logical merge conflicts.