Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel PipelineExecutor properly in case of exception in spawnThreads #57104

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Cancel PipelineExecutor properly in case of exception in spawnThreads #57104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/Processors/Executors/PipelineExecutor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,8 +300,18 @@ void PipelineExecutor::executeStepImpl(size_t thread_num, std::atomic_bool * yie
context.processing_time_ns += processing_time_watch.elapsed();
#endif

/// Upscale if possible.
spawnThreads();
try
{
/// Upscale if possible.
spawnThreads();
}
catch (...)
{
/// spawnThreads can throw an exception, for example CANNOT_SCHEDULE_TASK.
/// We should cancel execution properly before rethrow.
cancel();
throw;
}

/// We have executed single processor. Check if we need to yield execution.
if (yield_flag && *yield_flag)
Expand Down