Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix occasional slowness of stack unwinding. #57221

Merged
merged 2 commits into from Nov 25, 2023
Merged

Conversation

alexey-milovidov
Copy link
Member

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

There are cases when stack unwinding was slow.

Extracted commits from #57180.

@robot-ch-test-poll2 robot-ch-test-poll2 added pr-performance Pull request with some performance improvements submodule changed At least one submodule changed in this PR. labels Nov 25, 2023
@robot-ch-test-poll2
Copy link
Contributor

robot-ch-test-poll2 commented Nov 25, 2023

This is an automated comment for commit 5eb3caf with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

@alexey-milovidov alexey-milovidov merged commit 4aff43e into master Nov 25, 2023
278 of 300 checks passed
@alexey-milovidov alexey-milovidov deleted the faster-libunwind branch November 25, 2023 20:13
@alexey-milovidov alexey-milovidov self-assigned this Nov 25, 2023
@alexey-milovidov
Copy link
Member Author

Before:

milovidov@milovidov-desktop:~/work/ClickHouse/build_test$ clickhouse-client 
ClickHouse client version 23.11.1.1.
Connecting to localhost:9000 as user default.
Connected to ClickHouse server version 23.11.1 revision 54466.

Warnings:
 * Delay accounting is not enabled, OSIOWaitMicroseconds will not be gathered. Check /proc/sys/kernel/task_delayacct

milovidov-desktop :) SELECT count() FROM numbers(10) SETTINGS memory_profiler_sample_probability = 1, max_untracked_memory = 0

SELECT count()
FROM numbers(10)
SETTINGS memory_profiler_sample_probability = 1, max_untracked_memory = 0

Query id: 57a1c7ea-7191-4ca7-8a87-148627a1382e

┌─count()─┐
│      10 │
└─────────┘

1 row in set. Elapsed: 0.244 sec. 

milovidov-desktop :) SELECT count() FROM numbers(10) SETTINGS memory_profiler_sample_probability = 1, max_untracked_memory = 0

SELECT count()
FROM numbers(10)
SETTINGS memory_profiler_sample_probability = 1, max_untracked_memory = 0

Query id: 343b8596-aa4f-412e-aaca-dae5553a3448

┌─count()─┐
│      10 │
└─────────┘

1 row in set. Elapsed: 0.200 sec. 

milovidov-desktop :) SELECT count() FROM numbers(10) SETTINGS memory_profiler_sample_probability = 1, max_untracked_memory = 0

SELECT count()
FROM numbers(10)
SETTINGS memory_profiler_sample_probability = 1, max_untracked_memory = 0

Query id: 1243cbcc-b83a-4f36-9b77-1af25dbe21d1

┌─count()─┐
│      10 │
└─────────┘

1 row in set. Elapsed: 0.200 sec. 

milovidov-desktop :) SELECT count() FROM numbers(10) SETTINGS memory_profiler_sample_probability = 1, max_untracked_memory = 0

SELECT count()
FROM numbers(10)
SETTINGS memory_profiler_sample_probability = 1, max_untracked_memory = 0

Query id: ee2d56a8-896c-482a-8562-2dcef0e0b9b6

┌─count()─┐
│      10 │
└─────────┘

1 row in set. Elapsed: 8.430 sec.

After:

milovidov-desktop :) SELECT count() FROM numbers(10) SETTINGS memory_profiler_sample_probability = 1, max_untracked_memory = 0

SELECT count()
FROM numbers(10)
SETTINGS memory_profiler_sample_probability = 1, max_untracked_memory = 0

Query id: 82e3b774-1b8d-4943-b4b4-a54405f131d5

┌─count()─┐
│      10 │
└─────────┘

1 row in set. Elapsed: 0.228 sec. 

milovidov-desktop :) SELECT count() FROM numbers(10) SETTINGS memory_profiler_sample_probability = 1, max_untracked_memory = 0

SELECT count()
FROM numbers(10)
SETTINGS memory_profiler_sample_probability = 1, max_untracked_memory = 0

Query id: 83470237-3432-4bf0-8fbc-68999f3af860

┌─count()─┐
│      10 │
└─────────┘

1 row in set. Elapsed: 0.198 sec. 

milovidov-desktop :) SELECT count() FROM numbers(10) SETTINGS memory_profiler_sample_probability = 1, max_untracked_memory = 0

SELECT count()
FROM numbers(10)
SETTINGS memory_profiler_sample_probability = 1, max_untracked_memory = 0

Query id: fca9a11c-fc28-4fd2-9dda-1d6bdba4da59

┌─count()─┐
│      10 │
└─────────┘

1 row in set. Elapsed: 0.202 sec. 

milovidov-desktop :) SELECT count() FROM numbers(10) SETTINGS memory_profiler_sample_probability = 1, max_untracked_memory = 0

SELECT count()
FROM numbers(10)
SETTINGS memory_profiler_sample_probability = 1, max_untracked_memory = 0

Query id: 88ffaf8b-1608-44af-9590-e1438c530106

┌─count()─┐
│      10 │
└─────────┘

1 row in set. Elapsed: 1.397 sec.

(pay attention at the last number)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created-cloud pr-must-backport-cloud pr-performance Pull request with some performance improvements submodule changed At least one submodule changed in this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants