Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide a better hint if a table doesn't exist #57342

Merged

Conversation

bharatnc
Copy link
Contributor

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Better hints when a table doesn't exist.

When a table doesn't exist, search if the table exists in other databases and include the database and table in the hint. For example:

SELECT * FROM views;

Received exception from server (version 23.11.1):
Code: 60. DB::Exception: Received from localhost:9000. DB::Exception: Table default.VIEWS does not exist. Maybe you meant INFORMATION_SCHEMA.VIEWS?. (UNKNOWN_TABLE)

DROP TABLE query_log;

Received exception from server (version 23.11.1):
Code: 60. DB::Exception: Received from localhost:9000. DB::Exception: Table default.query_log does not exist. Maybe you meant system.query_log?. (UNKNOWN_TABLE)

Related to: #51168

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-improvement Pull request with some product improvements label Nov 29, 2023
@robot-clickhouse-ci-1
Copy link
Contributor

robot-clickhouse-ci-1 commented Nov 29, 2023

This is an automated comment for commit c9f35a8 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure

@bharatnc
Copy link
Contributor Author

cc: @alexey-milovidov

@yakov-olkhovskiy yakov-olkhovskiy self-assigned this Nov 29, 2023
@tavplubix
Copy link
Member

The implementation kind of duplicates TableNameHints added in #49801
Should we enhance TableNameHints instead?

cc: @yariks5s

@tavplubix
Copy link
Member

Also, does it allow bypassing SHOW_DATABASES/SHOW_TABLES restriction in RBAC?

@yariks5s
Copy link
Member

yariks5s commented Nov 29, 2023

The implementation kind of duplicates TableNameHints added in #49801 Should we enhance TableNameHints instead?

cc: @yariks5s

Yes, it is better to add this logic to TableNameHints so we will know that everything regarding hints is in the one place

@bharatnc
Copy link
Contributor Author

The implementation kind of duplicates TableNameHints added in #49801 Should we enhance TableNameHints instead?
cc: @yariks5s

Yes, it is better to add this logic to TableNameHints so we will know that everything regarding hints is in the one place

Thank you for the reviewing. I will make the changes.

@bharatnc bharatnc force-pushed the ncb/better-hint-if-table-doesnt-exist branch 2 times, most recently from a47b2c1 to 865ad6b Compare December 2, 2023 06:30
@bharatnc bharatnc force-pushed the ncb/better-hint-if-table-doesnt-exist branch 2 times, most recently from c3c3b50 to df4258e Compare December 4, 2023 04:13
@bharatnc bharatnc force-pushed the ncb/better-hint-if-table-doesnt-exist branch from df4258e to 25d1d59 Compare December 4, 2023 04:16
src/Interpreters/DatabaseCatalog.h Outdated Show resolved Hide resolved
src/Interpreters/DatabaseCatalog.h Outdated Show resolved Hide resolved
src/Interpreters/DatabaseCatalog.h Outdated Show resolved Hide resolved
@yariks5s yariks5s merged commit 325374c into ClickHouse:master Dec 15, 2023
338 of 343 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants