Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/more warnings #57375

Merged
merged 13 commits into from Dec 12, 2023
Merged

Conversation

lingtaolf
Copy link
Contributor

@lingtaolf lingtaolf commented Nov 30, 2023

Original issue: #56346

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add more warnings on the number of databases, tables.

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@hanfei1991 hanfei1991 added the can be tested Allows running workflows for external contributors label Nov 30, 2023
@hanfei1991
Copy link
Member

We can add some docs for the new settings

@hanfei1991 hanfei1991 self-assigned this Nov 30, 2023
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-feature Pull request with new product feature label Nov 30, 2023
@robot-ch-test-poll2
Copy link
Contributor

robot-ch-test-poll2 commented Nov 30, 2023

This is an automated comment for commit a96593c with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Docs CheckBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure

@lingtaolf lingtaolf changed the title Feature/more warnings Improvement/more warnings Nov 30, 2023
@lingtaolf lingtaolf changed the title Improvement/more warnings Feature/more warnings Dec 1, 2023
@robot-ch-test-poll robot-ch-test-poll added pr-improvement Pull request with some product improvements and removed pr-feature Pull request with new product feature labels Dec 1, 2023
@lingtaolf
Copy link
Contributor Author

We can add some docs for the new settings

Done

@lingtaolf
Copy link
Contributor Author

@hanfei1991 Should we add warning message for partition? But I am not sure where to get partition number, could you give me some advice?

@hanfei1991
Copy link
Member

@lingtaolf for this PR it's enough. There are also some style check failure. please fix it

Copy link

clickhouse-ci bot commented Dec 5, 2023

This is an automatic comment. The PR descriptions does not match the template.

Please, edit it accordingly.

The error is: Category 'Feature' is not valid

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-feature Pull request with new product feature label Dec 5, 2023
@robot-ch-test-poll2 robot-ch-test-poll2 removed the pr-improvement Pull request with some product improvements label Dec 5, 2023
@lingtaolf
Copy link
Contributor Author

@hanfei1991 Hi, here are some tests failed, but these seem to have nothing to do with my changes. Could you please take a look.

@hanfei1991 hanfei1991 merged commit 6abe4b1 into ClickHouse:master Dec 12, 2023
304 of 335 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-feature Pull request with new product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants