New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Intel-QAT-based ZSTD_QAT
compression codec
#57509
Conversation
This is an automated comment for commit ced9e93 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
Hi @jinjunzh , are there any benchmark data that you can share with us? I didn't see it from the [QAT ZSTD Plugin] repo. |
|
This comment was marked as outdated.
This comment was marked as outdated.
Note to myself: Force-disable setting |
@jinjunzh For validation and markeging purposes on your and our end, would you perhaps like to do some SQL-level benchmarks for ClickBench is popular around here but SSB may also do the job. Most of the infrastructure seems already there, though some of it was removed in the slightly impulsive #56898 (please bring the scripts back as needed). |
This comment was marked as outdated.
This comment was marked as outdated.
So I tried an in-tree build as my EC2 c7i instance has QuickAssist. This returned an error during insert into a I then tried an out-of-tree build using the documented steps (btw., is there any way to know if one needs an out-of-tree or an in-tree build? The log message is not very telling.). @jinjunzh Any input would be appreciated. Also, do you know if newer kernels no longer require the QAT driver, starting with some kernel version? |
@rschu1ze |
Previously, I've verified insert performance on local E2E test which works as expected. I will try to use ClickBench and give feedback to u once complete. |
Thanks. Compressing the hits csv/tsv/parquet file in ClickBench (section "Data Loading") with ZSTD vs. QATZST (possibly using different levels) should be fine. |
@rschu1ze For zlib question, i can't reproduce your issue, could you find zlib.h in your system, such as "/usr/include/zlib.h" or "/usr/local/include/zlib.h" ? |
@jinjunzh I followed the steps here until
I previously installed package |
@rschu1ze please look into your "/usr/include/zlib.h" and search zlib version as below: |
@jinjunzh My /usr/include/zlib.h includes |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Intel QuickAssist Technology (QAT) provides hardware-accelerated compression and cryptograpy. ClickHouse got a new compression codec
ZSTD_QAT
which utilizes QAT for zstd compression. The codec uses Intel's QATlib and Inte's QAT ZSTD Plugin. Right now, only compression can be accelerated in hardware (a software fallback kicks in in case QAT could not be initialized), decompression always runs in software.