New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SHARDS for HashedArrayDictionary #57544
Conversation
This is an automated comment for commit 398499d with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
2a45931
to
57e27e8
Compare
57e27e8
to
398499d
Compare
{ | ||
if constexpr (!sharded) | ||
return 0; | ||
return StringRefHash()(key) % configuration.shards; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StringRefHash
is the default hash for StringRef
, is it ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the same logic as in HashedDictionary.h
, but indeed it can be an issue (even comment above mentions it). I'll try to check if it should and can be improved.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
HASHED_ARRAY
(andCOMPLEX_KEY_HASHED_ARRAY
) layout supportsSHARDS
similarly toHASHED
.Documentation entry for user-facing changes