MaterializedPostgreSQL: Support "generated columns" and default values #57568

kssenii · 2023-12-06T14:05:52Z

Changelog category (leave one):

Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Support PostgreSQL generated columns and default column values in MaterializedPostgreSQL. Closes #40449.

robot-clickhouse · 2023-12-06T14:10:14Z

This is an automated comment for commit 1e4d61d with description of existing statuses. It's updated for the latest CI running

⏳ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker image for servers	The check to build and optionally push the mentioned image to docker hub	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
Mergeable Check	Checks if all other necessary checks are successful	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
Push to Dockerhub	The check for building and pushing the CI related docker images to docker hub	✅ success
SQLTest	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	✅ success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style Check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

Check name	Description	Status
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending

…-issue-with-generated-columns

…olumns

kssenii · 2023-12-11T10:07:16Z

No related failures:

Stateful tests (asan)

00180_no_seek_avoiding_when_reading_from_cache

Stateful tests (debug)

00180_no_seek_avoiding_when_reading_from_cache

Stateful tests (ubsan)

00180_no_seek_avoiding_when_reading_from_cache

…-issue-with-generated-columns

vdimir · 2023-12-11T10:21:19Z

src/Storages/PostgreSQL/StorageMaterializedPostgreSQL.cpp

@@ -195,7 +197,8 @@ void StorageMaterializedPostgreSQL::createNestedIfNeeded(PostgreSQLTableStructur
        const auto ast_create = getCreateNestedTableQuery(std::move(table_structure), table_override);
        auto table_id = getStorageID();
        auto tmp_nested_table_id = StorageID(table_id.database_name, getNestedTableName());
-        LOG_DEBUG(log, "Creating clickhouse table for postgresql table {}", table_id.getNameForLogs());
+        LOG_DEBUG(log, "Creating clickhouse table for postgresql table {} (ast: {})",
+                  table_id.getNameForLogs(), serializeAST(*ast_create));


BTW, we have IAST::formatForLogging that formats ast with settings suitable for logging (oneline, hide secrets, etc)

ClickHouse/src/Parsers/IAST.h

Line 283 in efb82a9

String formatForLogging(size_t max_length = 0) const

Doesn't make to much difference here, but just in case.

vdimir · 2023-12-11T10:23:23Z

src/Storages/PostgreSQL/PostgreSQLReplicationHandler.cpp

@@ -444,12 +447,16 @@ StorageInfo PostgreSQLReplicationHandler::loadFromSnapshot(postgres::Connection
    assertBlocksHaveEqualStructure(input->getPort().getHeader(), block_io.pipeline.getHeader(), "postgresql replica load from snapshot");
    block_io.pipeline.complete(Pipe(std::move(input)));

+    /// TODO: make a test when we fail in the middle of inserting data from source.


Perhaps introducing a fail point can make it easier to reproduce

ClickHouse/src/Common/FailPoint.cpp

Line 41 in efb82a9

REGULAR(dummy_failpoint) \

Wow, cool, did not know about that, thanks.
Though this comment can be removed, because a test to which this comment is referring was added in #57567.

vdimir · 2023-12-11T10:26:07Z

src/Storages/PostgreSQL/MaterializedPostgreSQLConsumer.cpp

+            columns_.begin(), columns_.end(),
+            [](const auto & col) { return col.name == "_sign" || col.name == "_version"; }))
+    {
+        throw Exception(ErrorCodes::LOGICAL_ERROR,


Can't user create a columns with such names somehow?

Yes, he can of course, this code checks if they were added during ALTER query after MaterializedPostgreSQL table was created successfully as there. But it is written in doc that these column names are reserved for internal usage.

Shouldn't it be another error code then LOGICAL_ERROR that indicated bug in out code?

Yes, good point.

vdimir · 2023-12-11T10:42:12Z

src/Storages/PostgreSQL/MaterializedPostgreSQLConsumer.cpp

@@ -507,47 +549,94 @@ void MaterializedPostgreSQLConsumer::processReplicationMessage(const char * repl
                return;
            }

+            auto log_table_structure_changed = [&](std::string_view reason)


I'm not entirely sure, but it seems like there might be a potential issue with the lifetime of the temporary std::string object returned by fmt::format.

Suggested change

auto log_table_structure_changed = [&](std::string_view reason)

auto log_table_structure_changed = [&](const std::string & reason)

tavplubix · 2023-12-13T18:42:39Z

Looks like it breaks test_postgresql_replica_database_engine_1: CI DB
Let's fix it quickly or revert

kssenii · 2023-12-14T13:05:31Z

Looks like it breaks test_postgresql_replica_database_engine_1: CI DB
Let's fix it quickly or revert

#57863

Follow up to #57568

azat · 2023-12-23T14:31:36Z

src/Databases/PostgreSQL/fetchPostgreSQLTableStructure.cpp

-                    columns.push_back(NameAndTypePair(std::get<0>(row), data_type));
+                    columns.push_back(NameAndTypePair(column_name, data_type));
+                    auto attgenerated = std::get<6>(row);
+                    LOG_TEST(&Poco::Logger::get("kssenii"), "KSSENII: attgenerated: {}", attgenerated);


Debug logging, I will remove it here - #58198

New PR - #58237

Support GENERATED and DEFAULT columns

8060616

robot-clickhouse added the pr-improvement Pull request with some product improvements label Dec 6, 2023

kssenii mentioned this pull request Dec 6, 2023

MaterializedPostgreSQL: Table is skipped from replication stream when using GENERATED columns #57197

Closed

kssenii and others added 5 commits December 6, 2023 16:47

Update fetchPostgreSQLTableStructure.cpp

9d8e3f8

Merge remote-tracking branch 'origin/master' into fix-materialized-pg…

ffd0d16

…-issue-with-generated-columns

Add validation of columns

d77938c

Test

0c40465

Merge branch 'master' into fix-materialized-pg-issue-with-generated-c…

928993f

…olumns

vdimir self-assigned this Dec 11, 2023

Merge remote-tracking branch 'origin/master' into fix-materialized-pg…

a06179d

…-issue-with-generated-columns

vdimir reviewed Dec 11, 2023

View reviewed changes

Review fixes

966a09f

vdimir approved these changes Dec 11, 2023

View reviewed changes

Change error code

1e4d61d

kssenii merged commit 907d0a7 into master Dec 11, 2023
326 of 332 checks passed

kssenii deleted the fix-materialized-pg-issue-with-generated-columns branch December 11, 2023 18:57

tavplubix mentioned this pull request Dec 13, 2023

Prepare the introduction of more keeper faults #56917

Merged

kssenii mentioned this pull request Dec 14, 2023

Follow up to #57568 #57863

Merged

kssenii added a commit that referenced this pull request Dec 15, 2023

Merge pull request #57863 from ClickHouse/fix-flaky-pg-test

f285a01

Follow up to #57568

azat reviewed Dec 23, 2023

View reviewed changes

natalyjazzviolin mentioned this pull request Mar 1, 2024

PostgreSQL table engine: Postgres 11 not supported as of 23.12 release #60651

Open

ischepin mentioned this pull request Apr 30, 2024

adnum logical error on postgres table SELECT query #63161

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MaterializedPostgreSQL: Support "generated columns" and default values #57568

MaterializedPostgreSQL: Support "generated columns" and default values #57568

kssenii commented Dec 6, 2023

robot-clickhouse commented Dec 6, 2023 •

edited by robot-ch-test-poll

kssenii commented Dec 11, 2023

vdimir Dec 11, 2023

vdimir Dec 11, 2023

kssenii Dec 11, 2023

vdimir Dec 11, 2023

kssenii Dec 11, 2023

vdimir Dec 11, 2023

kssenii Dec 11, 2023

vdimir Dec 11, 2023

tavplubix commented Dec 13, 2023 •

edited

kssenii commented Dec 14, 2023

azat Dec 23, 2023

kssenii Dec 23, 2023

azat Dec 27, 2023

	auto log_table_structure_changed = [&](std::string_view reason)
	auto log_table_structure_changed = [&](const std::string & reason)

MaterializedPostgreSQL: Support "generated columns" and default values #57568

MaterializedPostgreSQL: Support "generated columns" and default values #57568

Conversation

kssenii commented Dec 6, 2023

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

robot-clickhouse commented Dec 6, 2023 • edited by robot-ch-test-poll

kssenii commented Dec 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tavplubix commented Dec 13, 2023 • edited

kssenii commented Dec 14, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

robot-clickhouse commented Dec 6, 2023 •

edited by robot-ch-test-poll

tavplubix commented Dec 13, 2023 •

edited