New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sigabrt while getting PostgreSQL table structure #57618
Conversation
This is an automated comment for commit 4ef9065 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
Reproduced on our side in |
@jsc0218 If merged, backports to 23.8 would be highly appreciated |
Stacktrace we got
|
|
Unfortunately, we haven't been able to reproduce the bug every time, it's appearing every now and then. I've attached the stack trace. I will add the test but pretty sure it will be marked as flaky by CI. |
Changed from "bug fix" to "improvement". Now it will be acceptable without a test. |
…b259fc08eb0a452d4c71058c6459a Cherry pick #57618 to 23.3: Fix sigabrt while getting PostgreSQL table structure
…b259fc08eb0a452d4c71058c6459a Cherry pick #57618 to 23.8: Fix sigabrt while getting PostgreSQL table structure
…b259fc08eb0a452d4c71058c6459a Cherry pick #57618 to 23.9: Fix sigabrt while getting PostgreSQL table structure
…3b259fc08eb0a452d4c71058c6459a Cherry pick #57618 to 23.10: Fix sigabrt while getting PostgreSQL table structure
…3b259fc08eb0a452d4c71058c6459a Cherry pick #57618 to 23.11: Fix sigabrt while getting PostgreSQL table structure
Backport #57618 to 23.10: Fix sigabrt while getting PostgreSQL table structure
I doubt whether we should set it to 0, due to some limitation in postgres's array_ndims itself, please see cases detailed in issue#57436 |
Related: #57436 |
yes, so I think it is better to throw an exception instead of 0, due to the cases like first row null or empty while remaining rows are not. |
Well, at least we should catch that exception instead of sigabrt'ing. |
agree, let's take you approach as temporary, then approach in #57436 as a permanent. |
Backport #57618 to 23.3: Fix sigabrt while getting PostgreSQL table structure
Backport #57618 to 23.8: Fix sigabrt while getting PostgreSQL table structure
Backport #57618 to 23.9: Fix sigabrt while getting PostgreSQL table structure
Backport #57618 to 23.11: Fix sigabrt while getting PostgreSQL table structure
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Handle sigabrt case when getting PostgreSQl table structure with empty array