New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print pretty type names by default #57726
Conversation
This is an automated comment for commit 10ebe99 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
Co-authored-by: Kruglov Pavel <48961922+Avogar@users.noreply.github.com>
…ckHouse into pretty-type-names-default
…-type-names-default
<< elems[i]->getPrettyName(indent + 1); | ||
} | ||
|
||
s << ')'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed, why we don't print ')' on a separate line with indentation?
Is this:
Tuple(
a UInt32,
b Tuple(
c UInt32,
d String))
Better than this:
Tuple(
a UInt32,
b Tuple(
c UInt32,
d String
)
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No particular reason - I was formatting some examples, and found that this variant was more pleasant - but it might be a random preference.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
The setting
print_pretty_type_names
is turned on by default. You can turn it off to keep the old behavior orSET compatibility = '23.12'
.