New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallel replicas: announcement response handling improvement #57749
Conversation
This is an automated comment for commit 2a0a5f7 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
(1) if it's the same part (2) if annouced part has intersections with parts in working set
@serxa sorry, I came up with a better solution which covers the case when announced part can be covering/covered /by a part from parallel replicas working set P.S. Also, would like to add test for this case |
Sorry, came up with better solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks much better now!
Added test, it found a bug, the bug is fixed now
Tests failures
|
Test failures:
|
More efficient search for the same or covered/covering parts while building part's set (handling announcement response)
Changelog category (leave one):