Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply full-text skipping index when using hasAny() #57878

Merged
merged 3 commits into from Dec 17, 2023

Conversation

Jpnock
Copy link
Contributor

@Jpnock Jpnock commented Dec 14, 2023

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

The hasAny() function can now take advantage of the full-text skipping indices.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@CLAassistant
Copy link

CLAassistant commented Dec 14, 2023

CLA assistant check
All committers have signed the CLA.

@rschu1ze rschu1ze self-assigned this Dec 15, 2023
@rschu1ze rschu1ze added the can be tested Allows running workflows for external contributors label Dec 15, 2023
@rschu1ze rschu1ze marked this pull request as draft December 15, 2023 15:17
@robot-ch-test-poll robot-ch-test-poll added the pr-performance Pull request with some performance improvements label Dec 15, 2023
@robot-ch-test-poll
Copy link
Contributor

robot-ch-test-poll commented Dec 15, 2023

This is an automated comment for commit 2c24e43 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Docs CheckBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure

@rschu1ze rschu1ze changed the title WIP: Apply full-text skipping index when using hasAll() [wip] Apply full-text skipping index when using hasAll() Dec 15, 2023
@rschu1ze rschu1ze changed the title [wip] Apply full-text skipping index when using hasAll() [wip] Apply full-text skipping index when using hasAll() Dec 15, 2023
@Jpnock Jpnock changed the title [wip] Apply full-text skipping index when using hasAll() Apply full-text skipping index when using hasAll() Dec 15, 2023
@Jpnock Jpnock marked this pull request as ready for review December 15, 2023 21:33
@Jpnock Jpnock changed the title Apply full-text skipping index when using hasAll() Apply full-text skipping index when using hasAny() Dec 15, 2023
@Jpnock
Copy link
Contributor Author

Jpnock commented Dec 15, 2023

Check name Description Status
Integration tests The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests ❌ failure
Stress test Runs stateless functional tests concurrently from several clients to detect concurrency-related errors ❌ failure
Upgrade check Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts ❌ failure

As for the failing tests, they seem related to existing issues:

Integration test seems related to: #57651
Stress test seems related to: #57892
Upgrade check seems related to: #57893

@rschu1ze rschu1ze merged commit 7f675dd into ClickHouse:master Dec 17, 2023
350 of 353 checks passed
@rschu1ze
Copy link
Member

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-performance Pull request with some performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants