New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More efficient constructor for SerializationEnum #57887
Merged
rschu1ze
merged 2 commits into
ClickHouse:master
from
canhld94:ch_fast_enum_default_serialization
Dec 19, 2023
Merged
More efficient constructor for SerializationEnum #57887
rschu1ze
merged 2 commits into
ClickHouse:master
from
canhld94:ch_fast_enum_default_serialization
Dec 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
rschu1ze
reviewed
Dec 17, 2023
rschu1ze
reviewed
Dec 17, 2023
Co-authored-by: Robert Schulze <robert@clickhouse.com> Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
rschu1ze
approved these changes
Dec 18, 2023
rschu1ze
added
the
can be tested
Allows running workflows for external contributors
label
Dec 19, 2023
robot-ch-test-poll2
added
the
pr-not-for-changelog
This PR should not be mentioned in the changelog
label
Dec 19, 2023
This is an automated comment for commit b07cde5 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-not-for-changelog
This PR should not be mentioned in the changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: we use some long enum types with > 200 elements, and constructing serialisation for them is not trivial. But
getDefaultSerialization()
is used in many places, and it often appear in CPU profiling:The issue is: each calls to
getDefaultSerialization
create a copy ofEnumValues
(that is one vector and two maps) while it can reuse theEnumValues
fromDataTypeEnum
. So here this PR tries to do that.Changelog category (leave one):