Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #57907 from azat/system.stack_trace-rt_tgsigqueueinfo" #57974

Merged
merged 1 commit into from Dec 18, 2023

Conversation

alexey-milovidov
Copy link
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Our CI is broken - I will try to revert anything suspicious.
See https://s3.amazonaws.com/clickhouse-test-reports/57964/61e5db9cd0e03c272dff0f7d00d686d9f9e95a83/stateless_tests__release_.html

…igqueueinfo"

This reverts commit a33d6b0, reversing
changes made to cf031a1.
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Dec 18, 2023
@alexey-milovidov
Copy link
Member Author

CC @azat

@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented Dec 18, 2023

This is an automated comment for commit 2859ac0 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure

@alexey-milovidov
Copy link
Member Author

Wow, it helped!

Stateless tests (release) — fail: 0, passed: 5936, skipped: 4

@alexey-milovidov alexey-milovidov merged commit b0eb670 into master Dec 18, 2023
324 of 336 checks passed
@alexey-milovidov alexey-milovidov deleted the revert-stack-trace-changes branch December 18, 2023 03:50
@alexey-milovidov alexey-milovidov self-assigned this Dec 18, 2023
@azat
Copy link
Collaborator

azat commented Dec 18, 2023

Likely there are threads that blocks this signal, and the stack trace collecting in clickhouse-test simply contains "trash" data (though clickhouse-test has timeout for this query, but it is 30 seconds, and 60 retries, this is only half an hour, not 2 hours like you wrote)
Unlikely, but is there any chance that server logs could be obtained for that builds?

@azat
Copy link
Collaborator

azat commented Dec 18, 2023

Timeouts does not works correctly 100% there, while the query takes ~1min each (but still it is 1 hour not 2, whatever):

$ zstd -cdq clickhouse-server.log.zst | grep -F -a b7c4c147-903a-4eac-9a35-81f5b66844b0 | head -1
2023.12.17 00:19:10.969741 [ 418298 ] {b7c4c147-903a-4eac-9a35-81f5b66844b0} <Debug> executeQuery: (from [::1]:37706)  SELECT p.*, arrayStringConcat(groupArray('Thread ID ' || toString(s.thread_id) || '
$ zstd -cdq clickhouse-server.log.zst | grep -F -a b7c4c147-903a-4eac-9a35-81f5b66844b0 | wc -l
316
$ zstd -cdq clickhouse-server.log.zst | grep -F -a b7c4c147-903a-4eac-9a35-81f5b66844b0 | tail
2023.12.17 00:20:18.923769 [ 247423 ] {b7c4c147-903a-4eac-9a35-81f5b66844b0} <Debug> StorageSystemStackTrace: Cannot obtain a stack trace for thread 253368
2023.12.17 00:20:19.023949 [ 247423 ] {b7c4c147-903a-4eac-9a35-81f5b66844b0} <Debug> StorageSystemStackTrace: Cannot obtain a stack trace for thread 253764
2023.12.17 00:20:19.124121 [ 247423 ] {b7c4c147-903a-4eac-9a35-81f5b66844b0} <Debug> StorageSystemStackTrace: Cannot obtain a stack trace for thread 253767
2023.12.17 00:20:19.224288 [ 247423 ] {b7c4c147-903a-4eac-9a35-81f5b66844b0} <Debug> StorageSystemStackTrace: Cannot obtain a stack trace for thread 256029
2023.12.17 00:20:19.324463 [ 247423 ] {b7c4c147-903a-4eac-9a35-81f5b66844b0} <Debug> StorageSystemStackTrace: Cannot obtain a stack trace for thread 256209
2023.12.17 00:20:19.424646 [ 247423 ] {b7c4c147-903a-4eac-9a35-81f5b66844b0} <Debug> StorageSystemStackTrace: Cannot obtain a stack trace for thread 258973
2023.12.17 00:20:19.524816 [ 247423 ] {b7c4c147-903a-4eac-9a35-81f5b66844b0} <Debug> StorageSystemStackTrace: Cannot obtain a stack trace for thread 260059
2023.12.17 00:20:19.723426 [ 247423 ] {b7c4c147-903a-4eac-9a35-81f5b66844b0} <Debug> StorageSystemStackTrace: Cannot obtain a stack trace for thread 260060
2023.12.17 00:20:19.823598 [ 247423 ] {b7c4c147-903a-4eac-9a35-81f5b66844b0} <Debug> StorageSystemStackTrace: Cannot obtain a stack trace for thread 262086
2023.12.17 00:20:19.923797 [ 247423 ] {b7c4c147-903a-4eac-9a35-81f5b66844b0} <Debug> StorageSystemStackTrace: Cannot obtain a stack trace for thread 262088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants