New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid preprocessing on Keeper #58069
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonio2368
added
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
labels
Dec 20, 2023
robot-clickhouse-ci-1
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Dec 20, 2023
This is an automated comment for commit 3cc8358 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
nickitat
approved these changes
Dec 20, 2023
robot-ch-test-poll
added a commit
that referenced
this pull request
Dec 21, 2023
…3cde29db2e8c4e41725873c080036 Cherry pick #58069 to 23.3: Fix invalid preprocessing on Keeper
robot-clickhouse
added a commit
that referenced
this pull request
Dec 21, 2023
robot-ch-test-poll
added a commit
that referenced
this pull request
Dec 21, 2023
…3cde29db2e8c4e41725873c080036 Cherry pick #58069 to 23.8: Fix invalid preprocessing on Keeper
robot-clickhouse
added a commit
that referenced
this pull request
Dec 21, 2023
robot-ch-test-poll
added a commit
that referenced
this pull request
Dec 21, 2023
…3cde29db2e8c4e41725873c080036 Cherry pick #58069 to 23.9: Fix invalid preprocessing on Keeper
robot-clickhouse
added a commit
that referenced
this pull request
Dec 21, 2023
robot-ch-test-poll
added a commit
that referenced
this pull request
Dec 21, 2023
…23cde29db2e8c4e41725873c080036 Cherry pick #58069 to 23.10: Fix invalid preprocessing on Keeper
robot-clickhouse
added a commit
that referenced
this pull request
Dec 21, 2023
robot-ch-test-poll
added a commit
that referenced
this pull request
Dec 21, 2023
…23cde29db2e8c4e41725873c080036 Cherry pick #58069 to 23.11: Fix invalid preprocessing on Keeper
robot-clickhouse
added a commit
that referenced
this pull request
Dec 21, 2023
robot-ch-test-poll
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
Dec 21, 2023
robot-ch-test-poll
added a commit
that referenced
this pull request
Dec 21, 2023
Backport #58069 to 23.11: Fix invalid preprocessing on Keeper
antonio2368
added a commit
that referenced
this pull request
Dec 21, 2023
Backport #58069 to 23.3: Fix invalid preprocessing on Keeper
antonio2368
added a commit
that referenced
this pull request
Dec 21, 2023
Backport #58069 to 23.8: Fix invalid preprocessing on Keeper
antonio2368
added a commit
that referenced
this pull request
Dec 21, 2023
Backport #58069 to 23.9: Fix invalid preprocessing on Keeper
antonio2368
added a commit
that referenced
this pull request
Dec 21, 2023
Backport #58069 to 23.10: Fix invalid preprocessing on Keeper
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backports-created-cloud
pr-bugfix
Pull request with bugfix, not backported by default
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Keeper fix: Leader should correctly fail on preprocessing a request if it is not initialized.
Previously, leader node would simply return default
Ok
if it's not initialized which means that some request info is not correctly set (likeZXID
).Documentation entry for user-facing changes