Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base backup name to system.backups and system.backup_log tables #58178

Conversation

chhetripradeep
Copy link
Contributor

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Why

Currently we don't capture any base backup information for an incremental backup in system tables. Thus the only way to find out which base backup an incremental backup is build upon is by using system.query_log. I think we can have base backup information in system tables which will be useful.

Test locally via:

:) BACKUP TABLE test.table TO Disk('backups', '1.zip')

┌─id───────────────────────────────────┬─status─────────┐
│ 180c3e2e-56f1-4755-9422-798f53b40918 │ BACKUP_CREATED │
└──────────────────────────────────────┴────────────────┘

:) BACKUP TABLE test.table TO Disk('backups', 'inc-1.zip') SETTINGS base_backup = Disk('backups', '1.zip')

┌─id───────────────────────────────────┬─status─────────┐
│ ef14e271-1df2-42df-86c2-a0d490a73e0d │ BACKUP_CREATED │
└──────────────────────────────────────┴────────────────┘
:) select * from system.backups order by end_time \G

SELECT *
FROM system.backups
ORDER BY end_time ASC

Query id: ddfd06f4-5916-4e32-9098-e6ee980fa5a3

Row 1:
──────
id:                180c3e2e-56f1-4755-9422-798f53b40918
name:              Disk('backups', '1.zip')
base_backup_name:
status:            BACKUP_CREATED
...

Row 2:
──────
id:                ef14e271-1df2-42df-86c2-a0d490a73e0d
name:              Disk('backups', 'inc-1.zip')
base_backup_name:  Disk('backups', '1.zip')
status:            BACKUP_CREATED
...
:) select * from system.backup_log order by start_time \G

SELECT *
FROM system.backup_log
ORDER BY start_time ASC

Query id: 4bab215f-c13a-4228-9bdd-54b76c403ecc

Row 1:
──────
hostname:                Pradeeps-Laptop.local
event_date:              2023-12-23
event_time_microseconds: 2023-12-23 10:45:24.046735
id:                      180c3e2e-56f1-4755-9422-798f53b40918
name:                    Disk('backups', '1.zip')
base_backup_name:
status:                  CREATING_BACKUP
...

Row 2:
──────
hostname:                Pradeeps-Laptop.local
event_date:              2023-12-23
event_time_microseconds: 2023-12-23 10:45:24.048666
id:                      180c3e2e-56f1-4755-9422-798f53b40918
name:                    Disk('backups', '1.zip')
base_backup_name:
status:                  BACKUP_CREATED
...

Row 3:
──────
hostname:                Pradeeps-Laptop.local
event_date:              2023-12-23
event_time_microseconds: 2023-12-23 10:47:01.893280
id:                      ef14e271-1df2-42df-86c2-a0d490a73e0d
name:                    Disk('backups', 'inc-1.zip')
base_backup_name:        Disk('backups', '1.zip')
status:                  CREATING_BACKUP
...

Row 4:
──────
hostname:                Pradeeps-Laptop.local
event_date:              2023-12-23
event_time_microseconds: 2023-12-23 10:47:01.895341
id:                      ef14e271-1df2-42df-86c2-a0d490a73e0d
name:                    Disk('backups', 'inc-1.zip')
base_backup_name:        Disk('backups', '1.zip')
status:                  BACKUP_CREATED
...

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Dec 23, 2023
@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Dec 23, 2023
@robot-clickhouse-ci-2
Copy link
Contributor

robot-clickhouse-ci-2 commented Dec 23, 2023

This is an automated comment for commit b5c8c40 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

@alexey-milovidov alexey-milovidov self-assigned this Dec 24, 2023
@alexey-milovidov alexey-milovidov merged commit 00fa908 into ClickHouse:master Dec 24, 2023
349 of 353 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants