Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up iota (filling array with consecutive numbers) #58271

Merged
merged 9 commits into from Jan 4, 2024

Conversation

Algunenano
Copy link
Member

@Algunenano Algunenano commented Dec 28, 2023

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Speed up iota calls (filling array with consecutive numbers)

Affects many places where we need this kind of function.

I decided to only implement SSE42 (which was the default/baseline in official builds) and AVX2 (which gives 1.4x as much performance as SSE42) as I didn't see any improvement in introducing AVX512F or AVX512BW.

Here are the benchmarks I did:

clickhouse benchmark --port 49000 --timelimit 10 -q "SELECT * FROM numbers(50000000) format Null";
  • 23.10.1.1976 official build: localhost:49000, queries: 1149, QPS: 114.765, RPS: 5742591296.002, MiB/s: 43812.495, result RPS: 0.000, result MiB/s: 0.000.
  • Master: localhost:49000, queries: 1128, QPS: 112.582, RPS: 5629122754.909, MiB/s: 42946.798, result RPS: 0.000, result MiB/s: 0.000.
  • Changes SSE42: localhost:49000, queries: 1120, QPS: 111.864, RPS: 5593191769.538, MiB/s: 42672.667, result RPS: 0.000, result MiB/s: 0.000.
  • Changes AVX2: localhost:49000, queries: 1501, QPS: 149.953, RPS: 7497625872.771, MiB/s: 57202.346, result RPS: 0.000, result MiB/s: 0.000.
  • Changes AVX512F: localhost:49000, queries: 1480, QPS: 147.832, RPS: 7391576269.195, MiB/s: 56393.252, result RPS: 0.000, result MiB/s: 0.000.
  • Changes AVX512BW: localhost:49000, queries: 1486, QPS: 148.394, RPS: 7419700525.981, MiB/s: 56607.823, result RPS: 0.000, result MiB/s: 0.000.

Other affected functions are:

  • rowNumberInBlock
  • arraySort
  • Anything that uses permutations (ORDER BY)

@Algunenano Algunenano added the 🎅 🎁 gift🎄 To make people wonder label Dec 28, 2023
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-performance Pull request with some performance improvements label Dec 28, 2023
@robot-ch-test-poll2
Copy link
Contributor

robot-ch-test-poll2 commented Dec 28, 2023

This is an automated comment for commit ff90f64 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure

@alexey-milovidov alexey-milovidov self-assigned this Dec 28, 2023
@Algunenano Algunenano marked this pull request as ready for review December 28, 2023 12:53
@Algunenano Algunenano marked this pull request as draft December 28, 2023 22:22
@Algunenano
Copy link
Member Author

Turns out that when working on min for non numeric types I noticed that getPermutationImpl could use a similar improvement. Let's move this new iota to somewhere where it can be used in more places.

@Algunenano Algunenano changed the title Speed up numbers table function Speed up iota (filling array with consecutive numbers) Dec 29, 2023
@Algunenano Algunenano marked this pull request as ready for review December 29, 2023 17:17
@Algunenano
Copy link
Member Author

To check:

  • Darwin builds: It seems that unsigned long does not match any of UInt8, UInt32, UInt64. OSX hates developers. I'll look for an alternative to declare it conditionally.
  • Review the negative change in performance.

@alexey-milovidov
Copy link
Member

alexey-milovidov commented Dec 30, 2023

@Algunenano, Mac OS defines size_t as unsigned long long instead of unsigned long.

@Algunenano
Copy link
Member Author

Fixed the OSX build and verified locally that indeed a couple of tests were slower with the changes. I couldn't see why and it went away as soon as I rebased the branch with master, so let's see what it says now.

@Algunenano
Copy link
Member Author

Test diffs in Performance Comparison [2/4] seem unrelated. They do not reproduce locally and I don't see any calls to iota being made

@Algunenano Algunenano merged commit 971d030 into ClickHouse:master Jan 4, 2024
269 of 271 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎅 🎁 gift🎄 To make people wonder pr-performance Pull request with some performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants