New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sparkBar as an alias to sparkbar #58335
sparkBar as an alias to sparkbar #58335
Conversation
@@ -378,6 +378,7 @@ AggregateFunctionPtr createAggregateFunctionSparkbar(const std::string & name, c | |||
void registerAggregateFunctionSparkbar(AggregateFunctionFactory & factory) | |||
{ | |||
factory.registerFunction("sparkbar", createAggregateFunctionSparkbar); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to simply just do:
factory.registerFunction("sparkbar", createAggregateFunctionSparkbar); | |
factory.registerFunction("sparkbar", createAggregateFunctionSparkbar, AggregateFunctionFactory::CaseInsensitive); |
In this way, it will cover additional cases too like sparkBar
, SparkBar
, 'Sparkbar' etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bharatnc I'm not sure covering all situations is what they need.
This is an automated comment for commit 57c5736 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
Thank you! I like the current way, where the function is case-sensitive with just two options. |
resolved: #58283
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
sparkBar as an alias to sparkbar
Documentation entry for user-facing changes