New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add settings for better control of indexes type in Arrow dictionary #58519
Add settings for better control of indexes type in Arrow dictionary #58519
Conversation
This is an automated comment for commit 8d7c24a with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
@@ -14,15 +14,33 @@ namespace DB | |||
class CHColumnToArrowColumn | |||
{ | |||
public: | |||
CHColumnToArrowColumn(const Block & header, const std::string & format_name_, bool low_cardinality_as_dictionary_, bool output_string_as_string_, bool output_fixed_string_as_fixed_byte_array_); | |||
struct Settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to pass 5 different bool flags into CHColumnToArrowColumn
constructor, so I decided to move them to a separate struct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Let's add at least something as a test.
13691c0
to
010b15b
Compare
…Use signed integer type for indexes by default
a349507
to
8d7c24a
Compare
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240114) * fix build due to ClickHouse/ClickHouse#58772 * fix build due to ClickHouse/ClickHouse#58519 --------- Co-authored-by: kyligence-git <gluten@kyligence.io> Co-authored-by: Chang Chen <baibaichen@gmail.com>
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add settings for better control of indexes type in Arrow dictionary. Use signed integer type for indexes by default as Arrow recommends. Closes #57401
Documentation entry for user-facing changes