New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove order by requierement in PASTE JOIN #58608
Merged
vdimir
merged 6 commits into
ClickHouse:master
from
yariks5s:remove_order_by_requirement_paste_join
Jan 10, 2024
Merged
Remove order by requierement in PASTE JOIN #58608
vdimir
merged 6 commits into
ClickHouse:master
from
yariks5s:remove_order_by_requirement_paste_join
Jan 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll
added
the
pr-improvement
Pull request with some product improvements
label
Jan 8, 2024
This is an automated comment for commit aef24c0 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
vdimir
reviewed
Jan 9, 2024
@@ -32,6 +32,6 @@ INSERT INTO t2 SELECT number, number FROM numbers(15, 15); | |||
SELECT * FROM ( SELECT * from t1 ) t1 PASTE JOIN ( SELECT * from t2 ) t2 SETTINGS max_threads = 1; | |||
SELECT toTypeName(a) FROM (SELECT number as a FROM numbers(11)) t1 PASTE JOIN (select number as a from numbers(10)) t2 SETTINGS join_use_nulls = 1; | |||
SET max_threads = 2; | |||
select * from (SELECT number as a FROM numbers_mt(10)) t1 PASTE JOIN (select number as a from numbers(10) ORDER BY a DESC) t2 SETTINGS max_block_size=10; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add note into docs that in that case result can be nondeterministic (and add an example)
…ariks5s/ClickHouse into remove_order_by_requirement_paste_join
vdimir
approved these changes
Jan 10, 2024
robot-ch-test-poll3
added a commit
that referenced
this pull request
Jan 10, 2024
…79d58e50cc7502b28968e5f469afd7 Cherry pick #58608 to 23.12: Remove order by requierement in PASTE JOIN
robot-clickhouse
added a commit
that referenced
this pull request
Jan 10, 2024
robot-ch-test-poll3
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
Jan 10, 2024
alexey-milovidov
added a commit
that referenced
this pull request
Jan 10, 2024
Backport #58608 to 23.12: Remove order by requierement in PASTE JOIN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-improvement
Pull request with some product improvements
v23.12-must-backport
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
When executing some queries, which require a lot of streams for reading data, the error
"Paste JOIN requires sorted tables only"
was previously thrown. Now the numbers of streams resize to 1 in that case.Documentation entry for user-facing changes