New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid alias duplicates in PASTE JOIN and fix aliases requirement #58654
Changes from 16 commits
daa231c
7a1c1a3
28eabae
d1f00b5
f656a6d
92c6eba
df8b29b
567e5d3
bfe76b1
157c596
eea8d2a
b4f078e
66f7100
243c37b
f05733e
38914ef
6ad6d6a
76b43a6
e28fd94
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1451,6 +1451,7 @@ const char * ParserAlias::restricted_keywords[] = | |
"ASOF", | ||
"BETWEEN", | ||
"CROSS", | ||
"PASTE", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Btw, I recently though about it and found out that it can be breaking change and we need to mention it properly in a changelog. Because |
||
"FINAL", | ||
"FORMAT", | ||
"FROM", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -82,3 +82,22 @@ UInt64 | |
7 2 | ||
8 1 | ||
9 0 | ||
0 0 | ||
1 1 | ||
2 2 | ||
3 3 | ||
4 4 | ||
5 5 | ||
0 0 | ||
1 1 | ||
2 2 | ||
3 3 | ||
4 4 | ||
5 5 | ||
0 0 | ||
1 1 | ||
2 2 | ||
3 3 | ||
4 4 | ||
5 5 | ||
1 2 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I already forgot what
table_expression_node
corresponds to. Why do we check only one node whilecheckDuplicateTableNamesOrAlias
expects left and right expression to be query ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We check only one node each time because we pass into
validateJoinTableExpressionWithoutAlias
only one argument (either left or right), so we call this function two times for each of the values.