Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SYSTEM commands and Keeper 4LW for jemalloc #58665

Merged
merged 2 commits into from Jan 12, 2024

Conversation

antonio2368
Copy link
Member

@antonio2368 antonio2368 commented Jan 10, 2024

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add SYSTEM JEMALLOC PURGE for purging unused jemalloc pages, SYSTEM JEMALLOC [ ENABLE | DISABLE | FLUSH ] PROFILE for controlling jemalloc profile if the profiler is enabled.
Add jemalloc-related 4LW command in Keeper: jmst for dumping jemalloc stats, jmfp, jmep, jmdp for controlling jemalloc profile if the profiler is enabled.

cc @KochetovNicolai

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-improvement Pull request with some product improvements label Jan 10, 2024
@robot-ch-test-poll4
Copy link
Contributor

robot-ch-test-poll4 commented Jan 10, 2024

This is an automated comment for commit d104072 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure

@antonio2368 antonio2368 force-pushed the jemalloc-system-commands branch 2 times, most recently from c389d88 to cdaab22 Compare January 10, 2024 16:12
@kssenii kssenii self-assigned this Jan 11, 2024
@antonio2368
Copy link
Member Author

Stress tests seem to be broken but unrelated to this PR

@antonio2368 antonio2368 merged commit 654fee8 into master Jan 12, 2024
262 of 267 checks passed
@antonio2368 antonio2368 deleted the jemalloc-system-commands branch January 12, 2024 09:08
@antonio2368 antonio2368 added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Jan 15, 2024
robot-ch-test-poll3 added a commit that referenced this pull request Jan 15, 2024
…0d54d2a7d9a7b0b861efeca1f77199

Cherry pick #58665 to 23.11: Add SYSTEM commands and Keeper 4LW for jemalloc
robot-ch-test-poll3 added a commit that referenced this pull request Jan 15, 2024
…0d54d2a7d9a7b0b861efeca1f77199

Cherry pick #58665 to 23.12: Add SYSTEM commands and Keeper 4LW for jemalloc
robot-ch-test-poll3 added a commit that referenced this pull request Jan 15, 2024
…d54d2a7d9a7b0b861efeca1f77199

Cherry pick #58665 to 23.3: Add SYSTEM commands and Keeper 4LW for jemalloc
robot-ch-test-poll3 added a commit that referenced this pull request Jan 15, 2024
…d54d2a7d9a7b0b861efeca1f77199

Cherry pick #58665 to 23.8: Add SYSTEM commands and Keeper 4LW for jemalloc
robot-ch-test-poll3 added a commit that referenced this pull request Jan 15, 2024
…0d54d2a7d9a7b0b861efeca1f77199

Cherry pick #58665 to 23.10: Add SYSTEM commands and Keeper 4LW for jemalloc
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jan 15, 2024
robot-clickhouse added a commit that referenced this pull request Jan 15, 2024
Backport #58665 to 23.11: Add SYSTEM commands and Keeper 4LW for jemalloc
robot-clickhouse-ci-1 added a commit that referenced this pull request Jan 15, 2024
Backport #58665 to 23.12: Add SYSTEM commands and Keeper 4LW for jemalloc
alexey-milovidov added a commit that referenced this pull request Jan 15, 2024
Backport #58665 to 23.3: Add SYSTEM commands and Keeper 4LW for jemalloc
alexey-milovidov added a commit that referenced this pull request Jan 15, 2024
Backport #58665 to 23.10: Add SYSTEM commands and Keeper 4LW for jemalloc
alexey-milovidov added a commit that referenced this pull request Jan 15, 2024
Backport #58665 to 23.8: Add SYSTEM commands and Keeper 4LW for jemalloc
amosbird pushed a commit to amosbird/ClickHouse that referenced this pull request Mar 5, 2024
…ommands

Add SYSTEM commands and Keeper 4LW for jemalloc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud pr-improvement Pull request with some product improvements pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants