New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix double destroy call on exception throw in addBatchLookupTable8 #58745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Algunenano
added
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
labels
Jan 12, 2024
robot-ch-test-poll3
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Jan 12, 2024
This is an automated comment for commit 0684cc7 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
devcrafter
reviewed
Jan 12, 2024
devcrafter
approved these changes
Jan 12, 2024
alexey-milovidov
approved these changes
Jan 13, 2024
robot-ch-test-poll1
added a commit
that referenced
this pull request
Jan 13, 2024
…aedb43ac90a310f233fd0e8266fd6 Cherry pick #58745 to 23.3: Fix double destroy call on exception throw in addBatchLookupTable8
robot-clickhouse
added a commit
that referenced
this pull request
Jan 13, 2024
…n addBatchLookupTable8
robot-ch-test-poll1
added a commit
that referenced
this pull request
Jan 13, 2024
…aedb43ac90a310f233fd0e8266fd6 Cherry pick #58745 to 23.8: Fix double destroy call on exception throw in addBatchLookupTable8
robot-clickhouse
added a commit
that referenced
this pull request
Jan 13, 2024
…n addBatchLookupTable8
robot-ch-test-poll1
added a commit
that referenced
this pull request
Jan 13, 2024
…3aedb43ac90a310f233fd0e8266fd6 Cherry pick #58745 to 23.10: Fix double destroy call on exception throw in addBatchLookupTable8
robot-clickhouse
added a commit
that referenced
this pull request
Jan 13, 2024
…in addBatchLookupTable8
robot-ch-test-poll1
added a commit
that referenced
this pull request
Jan 13, 2024
…3aedb43ac90a310f233fd0e8266fd6 Cherry pick #58745 to 23.11: Fix double destroy call on exception throw in addBatchLookupTable8
robot-clickhouse
added a commit
that referenced
this pull request
Jan 13, 2024
…in addBatchLookupTable8
robot-ch-test-poll1
added a commit
that referenced
this pull request
Jan 13, 2024
…3aedb43ac90a310f233fd0e8266fd6 Cherry pick #58745 to 23.12: Fix double destroy call on exception throw in addBatchLookupTable8
robot-clickhouse
added a commit
that referenced
this pull request
Jan 13, 2024
…in addBatchLookupTable8
robot-ch-test-poll1
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
Jan 13, 2024
Algunenano
added a commit
that referenced
this pull request
Jan 13, 2024
Backport #58745 to 23.3: Fix double destroy call on exception throw in addBatchLookupTable8
Algunenano
added a commit
that referenced
this pull request
Jan 13, 2024
Backport #58745 to 23.11: Fix double destroy call on exception throw in addBatchLookupTable8
Algunenano
added a commit
that referenced
this pull request
Jan 13, 2024
Backport #58745 to 23.12: Fix double destroy call on exception throw in addBatchLookupTable8
Algunenano
added a commit
that referenced
this pull request
Jan 13, 2024
Backport #58745 to 23.10: Fix double destroy call on exception throw in addBatchLookupTable8
Algunenano
added a commit
that referenced
this pull request
Jan 13, 2024
Backport #58745 to 23.8: Fix double destroy call on exception throw in addBatchLookupTable8
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backports-created-cloud
pr-bugfix
Pull request with bugfix, not backported by default
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Documentation entry for user-facing changes
Closes #58727
The problem is that the pointer is assigned before create is called, so if create throws it keeps the assignment and will try to call destroy again later. All other calls to
createAggregateStates
are doing it correctly.